WiFi and NeoPixelBus Update #1
Open
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added hostname feature. Changed PixelBus method from 800kbps to DmaWS2812.
Update NeoPixelBus options to allow for the selection of output GPIO pin on ESP01/01-S when using WS2812x LEDs.
Removed unnecessary comments. Clarified remaining comments.
DjAngellas
commented
Mar 10, 2025
There was a problem hiding this comment.
GPIO0 is incorrect. NeoEsp8266DmaWs2812xMethod uses GPIO3.
lit_arduino.ino
Outdated
| @@ -14,7 +14,10 @@ const unsigned int port = 9000; | |||
| WiFiUDP socket; | |||
| char packetBuffer[PACKET_SIZE]; | |||
| uint64_t latestTimestamp = 0; | |||
| NeoPixelBus<NeoGrbFeature, NeoEsp8266DmaWs2812xMethod> neopixels(NUM_LEDS); | |||
| //Uncomment NeoEsp8266DmaWs2812xMethod to use ESP01/01-S GPIO0 | |||
There was a problem hiding this comment.
Should read "//Uncomment NeoEsp8266DmaWs2812xMethod to use ESP01/01-S GPIO3"
"//Uncomment NeoEsp8266DmaWs2812xMethod to use ESP01/01-S GPIO0" corrected to "//Uncomment NeoEsp8266DmaWs2812xMethod to use ESP01/01-S GPIO3 / RX"
nickpesce
requested changes
Mar 10, 2025
| @@ -9,11 +9,16 @@ | |||
|
|
|||
| const char* ssid = "OMITTED"; | |||
| const char* password = "OMITTED"; | |||
| const char* hostname = "OMITTED"; | |||
There was a problem hiding this comment.
Can this be made optional? Maybe by just not calling wifi.hostname if the hostname an empty string (and make "" the default). I'd like to keep it possible to install the same image on multiple devices without duplicate hostname issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ESP8266WiFi options to include hostname in order to allow for easier identification of hosts within the network.
Update NeoPixelBus options to permit using GPIO0 or GPIO2 on the ESP01/01-S platform.
Comment cleanup and clarification.