Skip to content

[mlir][python] Fix some mypy violations (NFC) #110606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[mlir][python] Fix some mypy violations (NFC) #110606

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
341aef0
[mlir][python] Fix some mypy violations (NFC)
keith Oct 1, 2024
c84c143
lint
keith Oct 1, 2024
2089120
union not tuple
keith Oct 1, 2024
64550c8
remove union
keith Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions mlir/python/mlir/dialects/_ods_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

from typing import (
Any as _Any,
List as _List,
Optional as _Optional,
Sequence as _Sequence,
Expand All @@ -12,7 +13,7 @@
)

from .._mlir_libs import _mlir as _cext
from ..ir import (
from ..ir import ( # type: ignore
ArrayAttr,
Attribute,
BoolAttr,
Expand Down Expand Up @@ -244,8 +245,8 @@ def _dispatch_mixed_values(


def _get_value_or_attribute_value(
value_or_attr: _Union[any, Attribute, ArrayAttr]
) -> any:
value_or_attr: _Union[_Any, Attribute, ArrayAttr]
) -> _Any:
if isinstance(value_or_attr, Attribute) and hasattr(value_or_attr, "value"):
return value_or_attr.value
if isinstance(value_or_attr, ArrayAttr):
Expand All @@ -254,8 +255,8 @@ def _get_value_or_attribute_value(


def _get_value_list(
sequence_or_array_attr: _Union[_Sequence[any], ArrayAttr]
) -> _Sequence[any]:
sequence_or_array_attr: _Union[_Sequence[_Any], ArrayAttr]
) -> _Sequence[_Any]:
return [_get_value_or_attribute_value(v) for v in sequence_or_array_attr]


Expand Down
Loading