Skip to content

Fixed vec_pack_to_short_fp32 in Clang altivec.h #129923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fixed vec_pack_to_short_fp32 in Clang altivec.h #129923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0bfa20f
Fixed vec_pack_to_short_fp32 in Clang altivec.h
johnplatts Mar 5, 2025
51c0579
add additional checks to test for vec_pack_to_short_fp32
lei137 Mar 7, 2025
ee4c4e5
Merge remote-tracking branch 'lei137_llvm/lei/addNFCtest' into clang_…
johnplatts Mar 7, 2025
9aed4ea
Updated test to reflect changes made to vec_pack_to_short_fp32
johnplatts Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions clang/lib/Headers/altivec.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7529,13 +7529,9 @@ vec_pack(vector double __a, vector double __b) {
#ifdef __POWER9_VECTOR__
static __inline__ vector unsigned short __ATTRS_o_ai
vec_pack_to_short_fp32(vector float __a, vector float __b) {
vector float __resa = __builtin_vsx_xvcvsphp(__a);
vector float __resb = __builtin_vsx_xvcvsphp(__b);
#ifdef __LITTLE_ENDIAN__
return (vector unsigned short)vec_mergee(__resa, __resb);
#else
return (vector unsigned short)vec_mergeo(__resa, __resb);
#endif
vector unsigned int __resa = (vector unsigned int)__builtin_vsx_xvcvsphp(__a);
vector unsigned int __resb = (vector unsigned int)__builtin_vsx_xvcvsphp(__b);
return vec_pack(__resa, __resb);
}

#endif
Expand Down
8 changes: 6 additions & 2 deletions clang/test/CodeGen/PowerPC/builtins-ppc-p9vector.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,10 +853,14 @@ vector unsigned char test73(void) {
vector unsigned short test74(void) {
// CHECK-BE: @llvm.ppc.vsx.xvcvsphp(<4 x float>
// CHECK-BE: @llvm.ppc.vsx.xvcvsphp(<4 x float>
// CHECK-BE: @llvm.ppc.altivec.vperm
// CHECK-BE: [[REG0:%[0-9]+]] = call <4 x i32> @llvm.ppc.altivec.vperm
// CHECK-BE-NEXT: [[REG1:%[0-9]+]] = bitcast <4 x i32> [[REG0]] to <8 x i16>
// CHECK-BE-NEXT: ret <8 x i16> [[REG1]]
// CHECK: @llvm.ppc.vsx.xvcvsphp(<4 x float>
// CHECK: @llvm.ppc.vsx.xvcvsphp(<4 x float>
// CHECK: @llvm.ppc.altivec.vperm
// CHECK: [[REG0:%[0-9]+]] = call <4 x i32> @llvm.ppc.altivec.vperm
// CHECK-NEXT: [[REG1:%[0-9]+]] = bitcast <4 x i32> [[REG0]] to <8 x i16>
// CHECK-NEXT: ret <8 x i16> [[REG1]]
return vec_pack_to_short_fp32(vfa, vfb);
}
vector unsigned int test75(void) {
Expand Down