Skip to content

assert with more information to help debug #132194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

assert with more information to help debug #132194

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b30db3e
assert with more information to help debug
fengxie Mar 20, 2025
43bc949
fix a typo
fengxie Mar 20, 2025
1c7e1db
Merge branch 'main' into users/fengxie/mlir_python_improve_debug_info…
fengxie Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mlir/python/mlir/dialects/_ods_common.py
View file
Original file line number Diff line number Diff line change
@@ -105,7 +105,7 @@ def get_op_result_or_value(
elif isinstance(arg, _cext.ir.OpResultList):
return arg[0]
else:
assert isinstance(arg, _cext.ir.Value)
assert isinstance(arg, _cext.ir.Value), f"expects Value, got {type(arg)}"
return arg


@@ -147,6 +147,7 @@ def get_op_result_or_op_results(
else:
return op


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spurious change here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suspect introduced by auto formatter :(

ResultValueTypeTuple = _cext.ir.Operation, _cext.ir.OpView, _cext.ir.Value
ResultValueT = _Union[ResultValueTypeTuple]
VariadicResultValueT = _Union[ResultValueT, _Sequence[ResultValueT]]