ObjCARC: Drop pointer bitcast handling

[arsenm]

There is more in the file to drop, but this looks like the easier
part.

[arsenm]

• IR: Remove uselist for constantdata #134692
• SCEVExpander: Don't look at uses of constants #134691
• LICM: Avoid looking at use list of constant data #134690
• PHITransAddr: Avoid looking at constant use lists #134689
• SimplifyLibCalls: Skip sincospi optimization for ConstantData #134688
• ObjCARCContract: Use stripPointerCastsAndAliases #134275
• ObjCARC: Drop pointer bitcast handling #134274 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[llvmbot]

@llvm/pr-subscribers-llvm-transforms

Author: Matt Arsenault (arsenm)

Changes

There is more in the file to drop, but this looks like the easier
part.

---

Full diff: https://github.com/llvm/llvm-project/pull/134274.diff

1 Files Affected:

• (modified) llvm/lib/Transforms/ObjCARC/ObjCARCContract.cpp (-19)

diff --git a/llvm/lib/Transforms/ObjCARC/ObjCARCContract.cpp b/llvm/lib/Transforms/ObjCARC/ObjCARCContract.cpp
index 311d3b1cfc0a0..e11748b2c9dbb 100644
--- a/llvm/lib/Transforms/ObjCARC/ObjCARCContract.cpp
+++ b/llvm/lib/Transforms/ObjCARC/ObjCARCContract.cpp
@@ -660,7 +660,6 @@ bool ObjCARCContract::run(Function &F, AAResults *A, DominatorTree *D) {
     };
 
     Value *Arg = cast<CallInst>(Inst)->getArgOperand(0);
-    Value *OrigArg = Arg;
 
     // TODO: Change this to a do-while.
     for (;;) {
@@ -687,24 +686,6 @@ bool ObjCARCContract::run(Function &F, AAResults *A, DominatorTree *D) {
         break;
       }
     }
-
-    // Replace bitcast users of Arg that are dominated by Inst.
-    SmallVector<BitCastInst *, 2> BitCastUsers;
-
-    // Add all bitcast users of the function argument first.
-    for (User *U : OrigArg->users())
-      if (auto *BC = dyn_cast<BitCastInst>(U))
-        BitCastUsers.push_back(BC);
-
-    // Replace the bitcasts with the call return. Iterate until list is empty.
-    while (!BitCastUsers.empty()) {
-      auto *BC = BitCastUsers.pop_back_val();
-      for (User *U : BC->users())
-        if (auto *B = dyn_cast<BitCastInst>(U))
-          BitCastUsers.push_back(B);
-
-      ReplaceArgUses(BC);
-    }
   }
 
   // If this function has no escaping allocas or suspicious vararg usage,

[fhahn]

LGTM, thanks

[arsenm]

Merge activity

• Apr 7, 8:21 PM EDT: A user started a stack merge that includes this pull request via Graphite.
• Apr 7, 8:23 PM EDT: A user merged this pull request with Graphite.