Skip to content

[llvm][lto] Precommit test for libcall internalization #135705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[llvm][lto] Precommit test for libcall internalization #135705

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dddbf9
[llvm][lto] Precommit test for libcalls
ilovepi Apr 14, 2025
34d1490
Revise test checks, avoid instcombine, and use x86_64
ilovepi Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions llvm/test/LTO/Resolution/X86/bcmp-libcall.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
;; This test comes from a real world scenario in LTO, where the
;; definition of bcmp is deleted because it has no uses, but later instcombine
;; re-introduces a call to bcmp() as part of SimplifyLibCalls.

; RUN: opt %s -o %t -module-summary -mtriple x86_64-unknown-linux-musl
; RUN: llvm-lto2 run -o %t2 \
; RUN: -r %t,foo,plx \
; RUN: -r %t,memcmp,x \
; RUN: -r %t,bcmp,pl %t -save-temps
; RUN: llvm-dis %t2.1.2.internalize.bc -o - \
; RUN: | FileCheck %s

define i1 @foo(ptr %0, [2 x i32] %1) {
; CHECK-LABEL: define{{.*}}i1 @foo
; CHECK-NEXT: %size = extractvalue [2 x i32] %1, 1
; CHECK-NEXT: %cmp = {{.*}}call i32 @memcmp
; CHECK-NEXT: %eq = icmp eq i32 %cmp, 0
; CHECK-NEXT: ret i1 %eq

%size = extractvalue [2 x i32] %1, 1
%cmp = call i32 @memcmp(ptr %0, ptr null, i32 %size)
%eq = icmp eq i32 %cmp, 0
ret i1 %eq
}

; CHECK: declare i32 @memcmp(ptr, ptr, i32)
declare i32 @memcmp(ptr, ptr, i32)

;; Ensure bcmp is removed from module. Follow up patches can address this.
; CHECK-NOT: declare{{.*}}i32 @bcmp
; CHECK-NOT: define{{.*}}i32 @bcmp
define i32 @bcmp(ptr %0, ptr %1, i32 %2) {
ret i32 0
}

Loading