Skip to content

[SystemZ] Handle f16 load positive/negative/complement without libcalls. #136286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+46 −38
Open

[SystemZ] Handle f16 load positive/negative/complement without libcalls. #136286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions llvm/lib/Target/SystemZ/SystemZISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,8 @@ SystemZTargetLowering::SystemZTargetLowering(const TargetMachine &TM,
setOperationAction(ISD::BITCAST, MVT::i16, Custom);
setOperationAction(ISD::IS_FPCLASS, MVT::f16, Custom);
setOperationAction(ISD::FCOPYSIGN, MVT::f16, Legal);
for (auto Op : {ISD::FNEG, ISD::FABS})
setOperationAction(Op, MVT::f16, Legal);
}

for (unsigned I = MVT::FIRST_FP_VALUETYPE;
Expand Down
8 changes: 6 additions & 2 deletions llvm/lib/Target/SystemZ/SystemZInstrFP.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,8 +378,10 @@ let Defs = [CC], CCValues = 0xF, CompareZeroCCMask = 0xF in {
}
// Generic form, which does not set CC.
def LPDFR : UnaryRRE<"lpdfr", 0xB370, fabs, FP64, FP64>;
let isCodeGenOnly = 1 in
let isCodeGenOnly = 1 in {
def LPDFR_16 : UnaryRRE<"lpdfr", 0xB370, fabs, FP16, FP16>;
def LPDFR_32 : UnaryRRE<"lpdfr", 0xB370, fabs, FP32, FP32>;
}

// Negative absolute value (Load Negative).
let Defs = [CC], CCValues = 0xF, CompareZeroCCMask = 0xF in {
Expand All @@ -389,8 +391,10 @@ let Defs = [CC], CCValues = 0xF, CompareZeroCCMask = 0xF in {
}
// Generic form, which does not set CC.
def LNDFR : UnaryRRE<"lndfr", 0xB371, fnabs, FP64, FP64>;
let isCodeGenOnly = 1 in
let isCodeGenOnly = 1 in {
def LNDFR_16 : UnaryRRE<"lndfr", 0xB371, fnabs, FP16, FP16>;
def LNDFR_32 : UnaryRRE<"lndfr", 0xB371, fnabs, FP32, FP32>;
}

// Square root.
let Uses = [FPC], mayRaiseFPException = 1 in {
Expand Down
5 changes: 2 additions & 3 deletions llvm/test/CodeGen/SystemZ/fp-abs-01.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,9 @@
declare half @llvm.fabs.f16(half %f)
define half @f0(half %f) {
; CHECK-LABEL: f0:
; CHECK: brasl %r14, __extendhfsf2@PLT
; CHECK: # %bb.0:
; CHECK-NEXT: lpdfr %f0, %f0
; CHECK-NEXT: brasl %r14, __truncsfhf2@PLT
; CHECK: br %r14
; CHECK-NEXT: br %r14
%res = call half @llvm.fabs.f16(half %f)
ret half %res
}
Expand Down
12 changes: 12 additions & 0 deletions llvm/test/CodeGen/SystemZ/fp-abs-02.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,18 @@
; RUN: llc < %s -mtriple=s390x-linux-gnu -mcpu=z10 | FileCheck %s
; RUN: llc < %s -mtriple=s390x-linux-gnu -mcpu=z13 | FileCheck %s

; Test f16.
declare half @llvm.fabs.f16(half %f)
define half @f0(half %f) {
; CHECK-LABEL: f0:
; CHECK: # %bb.0:
; CHECK-NEXT: lndfr %f0, %f0
; CHECK-NEXT: br %r14
%abs = call half @llvm.fabs.f16(half %f)
%res = fneg half %abs
ret half %res
}

; Test f32.
declare float @llvm.fabs.f32(float %f)
define float @f1(float %f) {
Expand Down
5 changes: 2 additions & 3 deletions llvm/test/CodeGen/SystemZ/fp-abs-03.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,9 @@
declare half @llvm.fabs.f16(half %f)
define half @f0(half %f) {
; CHECK-LABEL: f0:
; CHECK: brasl %r14, __extendhfsf2@PLT
; CHECK: # %bb.0:
; CHECK-NEXT: lpdfr %f0, %f0
; CHECK-NEXT: brasl %r14, __truncsfhf2@PLT
; CHECK: br %r14
; CHECK-NEXT: br %r14
%res = call half @llvm.fabs.f16(half %f)
ret half %res
}
Expand Down
10 changes: 3 additions & 7 deletions llvm/test/CodeGen/SystemZ/fp-abs-04.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,9 @@
declare half @llvm.fabs.f16(half %f)
define half @f0(half %f) {
; CHECK-LABEL: f0:
; CHECK: brasl %r14, __extendhfsf2@PLT
; CHECK-NEXT: lpdfr %f0, %f0
; CHECK-NEXT: brasl %r14, __truncsfhf2@PLT
; CHECK-NEXT: brasl %r14, __extendhfsf2@PLT
; CHECK-NEXT: lcdfr %f0, %f0
; CHECK-NEXT: brasl %r14, __truncsfhf2@PLT
; CHECK: br %r14
; CHECK: # %bb.0:
; CHECK-NEXT: lndfr %f0, %f0
; CHECK-NEXT: br %r14
%abs = call half @llvm.fabs.f16(half %f)
%res = fneg half %abs
ret half %res
Expand Down
7 changes: 3 additions & 4 deletions llvm/test/CodeGen/SystemZ/fp-mul-08.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,12 @@ declare float @llvm.fma.f32(float %f1, float %f2, float %f3)

define half @f0(half %f1, half %f2, half %acc) {
; CHECK-LABEL: f0:
; CHECK: brasl %r14, __extendhfsf2@PLT
; CHECK: lcdfr %f0, %f0
; CHECK: brasl %r14, __truncsfhf2@PLT
; CHECK-NOT: brasl
; CHECK: lcdfr %f{{[0-9]+}}, %f4
; CHECK: brasl %r14, __extendhfsf2@PLT
; CHECK: brasl %r14, __extendhfsf2@PLT
; CHECK: brasl %r14, __extendhfsf2@PLT
; CHECK-SCALAR: maebr %f0, %f9, %f8
; CHECK-SCALAR: maebr %f0, %f8, %f10
; CHECK-VECTOR: wfmasb %f0, %f0, %f8, %f10
; CHECK: brasl %r14, __truncsfhf2@PLT
; CHECK: br %r14
Expand Down
21 changes: 10 additions & 11 deletions llvm/test/CodeGen/SystemZ/fp-mul-10.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ define half @f3_half(half %f1, half %f2, half %acc) {
; CHECK: brasl %r14, __extendhfsf2@PLT
; CHECK: wfmasb %f0, %f0, %f8, %f10
; CHECK: brasl %r14, __truncsfhf2@PLT
; CHECK: brasl %r14, __extendhfsf2@PLT
; CHECK: lcdfr %f0, %f0
; CHECK: brasl %r14, __truncsfhf2@PLT
; CHECK: br %r14
; CHECK-NOT: brasl
; CHECK: lcdfr %f0, %f0
; CHECK-NEXT: lmg
; CHECK-NEXT: br %r14
%res = call half @llvm.fma.f16 (half %f1, half %f2, half %acc)
%negres = fneg half %res
ret half %negres
Expand All @@ -50,18 +50,17 @@ define float @f3(float %f1, float %f2, float %acc) {

define half @f4_half(half %f1, half %f2, half %acc) {
; CHECK-LABEL: f4_half:
; CHECK: brasl %r14, __extendhfsf2@PLT
; CHECK: lcdfr %f0, %f0
; CHECK: brasl %r14, __truncsfhf2@PLT
; CHECK-NOT: brasl
; CHECK: lcdfr %f0, %f4
; CHECK: brasl %r14, __extendhfsf2@PLT
; CHECK: brasl %r14, __extendhfsf2@PLT
; CHECK: brasl %r14, __extendhfsf2@PLT
; CHECK: wfmasb %f0, %f0, %f8, %f10
; CHECK: brasl %r14, __truncsfhf2@PLT
; CHECK: brasl %r14, __extendhfsf2@PLT
; CHECK: lcdfr %f0, %f0
; CHECK: brasl %r14, __truncsfhf2@PLT
; CHECK: br %r14
; CHECK-NOT: brasl
; CHECK: lcdfr %f0, %f0
; CHECK-NEXT: lmg
; CHECK-NEXT: br %r14
%negacc = fneg half %acc
%res = call half @llvm.fma.f16 (half %f1, half %f2, half %negacc)
%negres = fneg half %res
Expand Down
7 changes: 3 additions & 4 deletions llvm/test/CodeGen/SystemZ/fp-neg-01.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,9 @@
; Test f16.
define half @f0(half %f) {
; CHECK-LABEL: f0:
; CHECK: brasl %r14, __extendhfsf2@PLT
; CHECK: lcdfr %f0, %f0
; CHECK: brasl %r14, __truncsfhf2@PLT
; CHECK: br %r14
; CHECK: # %bb.0:
; CHECK-NEXT: lcdfr %f0, %f0
; CHECK-NEXT: br %r14
%res = fneg half %f
ret half %res
}
Expand Down
7 changes: 3 additions & 4 deletions llvm/test/CodeGen/SystemZ/fp-neg-02.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,9 @@
; Test f16.
define half @f0(half %f) {
; CHECK-LABEL: f0:
; CHECK: brasl %r14, __extendhfsf2@PLT
; CHECK: lcdfr %f0, %f0
; CHECK: brasl %r14, __truncsfhf2@PLT
; CHECK: br %r14
; CHECK: # %bb.0:
; CHECK-NEXT: lcdfr %f0, %f0
; CHECK-NEXT: br %r14
%res = fneg half %f
ret half %res
}
Expand Down
Loading