[lld] NFC. Rename function to better reflect its implementation #136625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-lld Author: Pranav Kant (pranavk) ChangesFull diff: https://github.com/llvm/llvm-project/pull/136625.diff 1 Files Affected:
diff --git a/lld/ELF/ICF.cpp b/lld/ELF/ICF.cpp
index 849f6bdd445f9..fe18acc9bc5d9 100644
--- a/lld/ELF/ICF.cpp
+++ b/lld/ELF/ICF.cpp
@@ -120,7 +120,7 @@ template <class ELFT> class ICF {
void forEachClassRange(size_t begin, size_t end,
llvm::function_ref<void(size_t, size_t)> fn);
- void forEachClass(llvm::function_ref<void(size_t, size_t)> fn);
+ void parallelForEachClass(llvm::function_ref<void(size_t, size_t)> fn);
Ctx &ctx;
SmallVector<InputSection *, 0> sections;
@@ -433,7 +433,7 @@ void ICF<ELFT>::forEachClassRange(size_t begin, size_t end,
// Call Fn on each equivalence class.
template <class ELFT>
-void ICF<ELFT>::forEachClass(llvm::function_ref<void(size_t, size_t)> fn) {
+void ICF<ELFT>::parallelForEachClass(llvm::function_ref<void(size_t, size_t)> fn) {
// If threading is disabled or the number of sections are
// too small to use threading, call Fn sequentially.
if (parallel::strategy.ThreadsRequested == 1 || sections.size() < 1024) {
@@ -541,14 +541,14 @@ template <class ELFT> void ICF<ELFT>::run() {
// static content. Use a base offset for these IDs to ensure no overlap with
// the unique IDs already assigned.
uint32_t eqClassBase = ++uniqueId;
- forEachClass([&](size_t begin, size_t end) {
+ parallelForEachClass([&](size_t begin, size_t end) {
segregate(begin, end, eqClassBase, true);
});
// Split groups by comparing relocations until convergence is obtained.
do {
repeat = false;
- forEachClass([&](size_t begin, size_t end) {
+ parallelForEachClass([&](size_t begin, size_t end) {
segregate(begin, end, eqClassBase, false);
});
} while (repeat);
|
|
@llvm/pr-subscribers-lld-elf Author: Pranav Kant (pranavk) ChangesFull diff: https://github.com/llvm/llvm-project/pull/136625.diff 1 Files Affected:
diff --git a/lld/ELF/ICF.cpp b/lld/ELF/ICF.cpp
index 849f6bdd445f9..fe18acc9bc5d9 100644
--- a/lld/ELF/ICF.cpp
+++ b/lld/ELF/ICF.cpp
@@ -120,7 +120,7 @@ template <class ELFT> class ICF {
void forEachClassRange(size_t begin, size_t end,
llvm::function_ref<void(size_t, size_t)> fn);
- void forEachClass(llvm::function_ref<void(size_t, size_t)> fn);
+ void parallelForEachClass(llvm::function_ref<void(size_t, size_t)> fn);
Ctx &ctx;
SmallVector<InputSection *, 0> sections;
@@ -433,7 +433,7 @@ void ICF<ELFT>::forEachClassRange(size_t begin, size_t end,
// Call Fn on each equivalence class.
template <class ELFT>
-void ICF<ELFT>::forEachClass(llvm::function_ref<void(size_t, size_t)> fn) {
+void ICF<ELFT>::parallelForEachClass(llvm::function_ref<void(size_t, size_t)> fn) {
// If threading is disabled or the number of sections are
// too small to use threading, call Fn sequentially.
if (parallel::strategy.ThreadsRequested == 1 || sections.size() < 1024) {
@@ -541,14 +541,14 @@ template <class ELFT> void ICF<ELFT>::run() {
// static content. Use a base offset for these IDs to ensure no overlap with
// the unique IDs already assigned.
uint32_t eqClassBase = ++uniqueId;
- forEachClass([&](size_t begin, size_t end) {
+ parallelForEachClass([&](size_t begin, size_t end) {
segregate(begin, end, eqClassBase, true);
});
// Split groups by comparing relocations until convergence is obtained.
do {
repeat = false;
- forEachClass([&](size_t begin, size_t end) {
+ parallelForEachClass([&](size_t begin, size_t end) {
segregate(begin, end, eqClassBase, false);
});
} while (repeat);
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
pranavk
changed the title
MaskRay
approved these changes
Apr 25, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/16959 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/174/builds/17058 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.