socket: move frame creation after memory check in quic_sendmsg #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is better to create frames only after checking memory availability to avoid freeing a frame if the memory check fails. This patch updates the code accordingly for both handshake and datagram message sending. Since handshake data may be fragmented into multiple messages, it must first use len = 1 to check the wspace and calculate msg_len with wspace considered in quic_frame_crypto_create(), then perform a second wmem check after frame creation with the real msg_len, similar as what it does for stream data. Meanwhile, duplicate code in quic_frame_crypto_create() is removed. Reported-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Xin Long <lucien.xin@gmail.com>
|
close #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is better to create frames only after checking memory availability to avoid freeing a frame if the memory check fails. This patch updates the code accordingly for both handshake and datagram message sending.
Since handshake data may be fragmented into multiple messages, it must first use len = 1 to check the wspace and calculate msg_len with wspace considered in quic_frame_crypto_create(), then perform a second wmem check after frame creation with the real msg_len, similar as what it does for stream data.
Meanwhile, duplicate code in quic_frame_crypto_create() is removed.