Skip to content

Fix AbstractFieldArray with column renderers, Call setId() and setName(), remove workarounds #22009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: 2.4-develop
Choose a base branch
from
Open

Fix AbstractFieldArray with column renderers, Call setId() and setName(), remove workarounds #22009

wants to merge 15 commits into from

Conversation

Berdir
Copy link
Contributor

@Berdir Berdir commented Mar 28, 2019 •
edited by bgorski
Loading

Description (*)

See #22008.

The name and ID attributes aren't correctly set on custom renderers, and then implementations have all kinds of workarounds for that and require complex custom overrides to set the default attribute.

Fixed Issues (if relevant)

  1. Fixes Columns in AbstractFieldArray subclasses do not get their ID set correctly #22008: Columns in AbstractFieldArray subclasses do not get their ID set correctly
  2. ...

Manual testing scenarios (*)

  1. Go to Stores > Configuration > Catalog > Inventory
  2. Ensure that the Minimum Qty Allowed in Shopping Cart is working in the same way with all the removed code in \Magento\CatalogInventory\Block\Adminhtml\Form\Field\Minsaleqty

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @Berdir. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Mar 28, 2019
@Berdir
Copy link
Contributor Author

Berdir commented Apr 1, 2019

Pushed a fix for that failing test, that now also needs to use the setName() method and not setInputName().

I'm not sure abut the BC Policy, those removed methods could also be kept in case someone still needs them, with a @deprecated tag on it.

@orlangur
Copy link
Contributor

@magento run all tests

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:21
VladimirZaets
VladimirZaets requested changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@VladimirZaets VladimirZaets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Berdir. Thank for collaboration. Can you please update your PR due to Braintree module was removed from Magento codebase.

@ghost ghost assigned VladimirZaets Aug 3, 2020
@engcom-Charlie engcom-Charlie self-assigned this Aug 4, 2020
@ghost ghost added Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Priority: P3 May be fixed according to the position in the backlog. labels Aug 12, 2020
@engcom-Charlie
Merge branch '2.4-develop' into 22008-input-name-id
cefeaa8 
# Conflicts:
#	app/code/Magento/Braintree/Block/Adminhtml/Form/Field/Countries.php
#	app/code/Magento/Braintree/Block/Adminhtml/Form/Field/CountryCreditCard.php
#	dev/tests/integration/testsuite/Magento/CatalogInventory/Block/Adminhtml/Form/Field/CustomergroupTest.php
@engcom-Charlie
merge
5436ecf
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

Hi @Berdir, please sign CLA in otherwise we will not able to proceed with your PR.

@Berdir Berdir closed this Aug 18, 2020
@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo engcom-Echo self-assigned this Jul 18, 2024
@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Dash engcom-Dash self-assigned this Sep 30, 2024
@engcom-Dash engcom-Dash removed their assignment Sep 30, 2024
@engcom-Charlie engcom-Charlie self-assigned this Oct 3, 2024
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Dash engcom-Dash self-assigned this Jan 3, 2025
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Static Tests, Functional Tests EE, Functional Tests CE, Integration Tests

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

Moving it back to Pending Review for further review, as I made a few changes to the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgorski bgorski bgorski approved these changes

@VladimirZaets VladimirZaets Awaiting requested review from VladimirZaets

Assignees

@bgorski bgorski

@engcom-Charlie engcom-Charlie

@engcom-Echo engcom-Echo

@engcom-Dash engcom-Dash

Labels
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Component: CatalogInventory Component: Config Priority: P3 May be fixed according to the position in the backlog. Progress: ready for testing Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Status: Pending Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Columns in AbstractFieldArray subclasses do not get their ID set correctly