27550 - Fix UX issue on Admin > Content > Pages/Blocks grid

[Usik2203]

Description (*)

I want to share reasons why I have removed quick edit functionality on grid page

1. Most often Title, Url, and Layoutare permanent and need not quick editing on the grid page.
   Customer often edit Content ,Search Engine Optimization , Custom Design Update sections.
   We have to go to edit page any way
2. I as customer want to edit content quickly without redundant moves.
   But I have to do two clicks Select > Edit to go to edit section of Cms Page/Block.
   Sometimes even four clicks Click to need page/block -> cancel -> Select > Edit if I forgot about quick editing.

If I will edit Cms content very often It isn't user friendly interface for me and customers whole.

Yes we can apply this solution #27614 , yes it's good. But we can't get rid of two clicks to go to edit page.

I think removing quick editing functionality on the grid will save time people who works with Magento.
And they will spend this time for others things.

This PR adds such ability only One click on the grid and we are on the Edit page.
Also this PR fixed this issue #27550 It's one more confirmation than we need to avoid redundant clicks to go to Edit Cms Page/Blocks

Actual result Block grid

Actual result Page grid

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes UX issue on Admin > Content > Pages/Blocks grid #27550 : Fix UX issue on Admin > Content > Pages/Blocks grid

[m2-assistant]

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[Usik2203]

@magento give me test instance

[magento-engcom-team]

Hi @Usik2203. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @Usik2203, here is your new Magento instance.
Admin access: https://pr-27623.instances.magento-community.engineering/admin_f7df
Login: b19f1643 Password: e1db378667f3
Instance will be terminated in up to 3 hours.

[rogyar]

Hi @Usik2203. Thank you for your collaboration. That approach might be tricky. If I understand correctly, you just removed the inline edit possibility. In that way we are changing the existing system behavior.

I'm not sure we should simply remove this possibility (even if it's useless, I agree) from the product owners approval perspective. Maybe we should consider something like proposed in the following PR?

#27614

@ihor-sviziev what do you think?

[ihor-sviziev]

I would like just to drop it, but I agree that this change should be approved by product owner

…

On Sun, 5 Apr 2020 at 16:04, Yaroslav Rogoza ***@***.***> wrote: ***@***.**** requested changes on this pull request. Hi @Usik2203 <https://github.com/Usik2203>. Thank you for your collaboration. That approach might be tricky. If I understand correctly, you just removed the inline edit possibility. In that way we are changing the existing system behavior. I'm not sure we should simply remove this possibility (even if it's useless, I agree) from the product owners approval perspective. Maybe we should consider something like proposed in the following PR? #27614 <#27614> @ihor-sviziev <https://github.com/ihor-sviziev> what do you think? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#27623 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOJOUKZCYIAI76G2IAFYZTRLB6XTANCNFSM4MAQPO7Q> .

[rogyar]

Hi @Usik2203. Could I kindly ask you to extend the PR description slightly, please? So what is the main reason for your decision to remove this functionality but not to adjust it somehow. It's necessary for the final decision on how to proceed with the solution.

Thank you!

[Usik2203]

Hi @rogyar
I have updated description for this PR.
Thank you !

[rogyar]

Awesome, thank you. Now we need approval from product owners.

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-8408 has been created to process this Pull Request
✳️ @rogyar, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Charlie]

@magento run all tests

[Usik2203]

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

[gabrieldagama]

@magento run Functional Tests CE, Functional Tests B2B

[Usik2203]

HI @gabrieldagama
I see that failed tests are not related with my changes
Thanks

[gabrieldagama]

Hi @Usik2203,

Apparently, the tests introduced here are conflicting with other tests, maybe some tests missed to clear their filters and are causing this to failed. Can we make sure the filters are clear before performing the action? Please follow screenshots below.

Also, we do need the approval of PO on this functional change, once that is fixed we need to move this to the Pending Approval column.

Thanks.

[Usik2203]

@gabrieldagama Can we make sure the filters are clear before performing the action?
I didn't find way to do this .
Yes, I can create additional assertion to be sure that filters are clear but in case is it will not be true test will be failed.
Now tests looks good.

Thanks

[gabrieldagama]

@Usik2203 the tests are failing on internal builds, please add the following to your tests:

<actionGroup ref="ClearFiltersAdminDataGridActionGroup" stepKey="clearProductsGridFilters"/>

[Usik2203]

@magento run all tests

[Usik2203]

@Usik2203 the tests are failing on internal builds, please add the following to your tests:

<actionGroup ref="ClearFiltersAdminDataGridActionGroup" stepKey="clearProductsGridFilters"/>

@gabrieldagama Thank you for advice.