Added processing of missed 'Fields enclosure' on admin exports

[elevinskii]

Description

The value of "Fields Enclosure" checkbox on admin export page (System -> Export) is not passed to appropriate export model, therefore enclosure behavior is not handled.
This Pull Request is fixing that.

Manual testing scenarios

1. Ensure you have some products and custom attributes.
2. Export products through backend with the parameters:

• Entity Type: Products
• Export File Format: CSV
• Fields Enclosure: Yes

3. Download and open generated CSV file.

All attribute values in additional_attributes column must be wrapped by double quotes ", but they aren't.

Related Issues

Probably, it's worth to mention here closed issue #14642, there was the similar problem with skip_attr field.

Resolved issues:

1. resolves [Issue] Added processing of missed 'Fields enclosure' on admin exports #29554: Added processing of missed 'Fields enclosure' on admin exports

[m2-assistant]

Hi @elevinskii. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[aleron75]

Hello @elevinskii thanks for your contribution!

Due to Magento Definition of Done, all code must be covered by tests.

For this specific case, this fix should be covered by automated tests with the scenario which leads to an issue: tests should fail on the mainline and pass with this fix.

To answer the question "which kind of tests should we write", the general answer is: let's pick the most lightweight (execution time-wise) test type that will provide sufficient coverage.

I would recommend an integration test.

Thank you again!

[aleron75]

Hello @elevinskii do you think you will be able to provide the requested test?
Let me know, thank you!

[elevinskii]

@aleron75 Thanks for following this up!
Definitely, I will be, give me a bit time.

[sidolov]

@magento create issue

[joshuaswarren]

Hello, @elevinskii - thank you for your support of the Magento community and your efforts on this pull request! It's been three years since that added test coverage was requested before this PR could be considered for merging into the core Magento codebase, and there hasn't been an update. Are you still working on the Magento platform? Would you be able to add those tests? Also, are you aware if the issue fixed by this PR is still occurring on the newer versions of Magento that have been released in the past few years?