-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Disable show ObjectManager/Models/Collection internals with var_dump #30326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kandy
wants to merge
16
commits into
magento:2.4-develop
Choose a base branch
from
kandy:om-debuginfo
base: 2.4-develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
08bb71c
Disable show ObjectManager internals with var_dump
kandy 9650391
Export scalar/array properties for var_dump
kandy 03f41a9
Fix static test
kandy e9f51e6
fix static test
kandy 8f28a87
fix static test
kandy 7b32965
fix static test
kandy 5b4d5ad
Fix static test test massage
kandy ae0bc66
Fix static test test massage
kandy 442e3ed
Fix static test test massage
kandy 0d998ac
Merge branch '2.4-develop' of github.com:magento/magento2 into om-deb…
kandy 9ea3fed
Merge branch '2.4-develop' into om-debuginfo
kandy 763300b
Merge branch '2.4-develop' of github.com:magento/magento2 into om-deb…
kandy 8f4f229
Merge remote-tracking branch 'mainline/2.4-develop' into om-debuginfo
kandy b3c8cef
Static test
kandy adc8ff4
Return annotation
kandy bfe74cc
Merge branch '2.4-develop' into om-debuginfo
kandy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also not clear why you changed interface here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ArrayInterface is deprecated.
see https://github.com/magento/magento2/blob/2.4-develop/lib/internal/Magento/Framework/Option/ArrayInterface.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it’s not really related to the name of this PR, also this isn’t backward compatible change. Can we extract it to separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, i see that svc fails anyway, so we’ll need approval. No need to do anything