Skip to content

#30199 Fixed "Learn More should be See details/More Details as Customer see the product details not learn anything" #30392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

surabhisrivastava09
Copy link
Member

Fixed #30199 "Learn More should be See details/More Details as Customer see the product details not learn anything"

Description (*)

Learn More should be See details/More Details as Customer see the product details not learn anything
94336072-d09d4d00-fffd-11ea-99ab-9a6a67206c9a

(/) Expected result
Learn More should be See details/More Details as Customer see the product details not learn anything

Benefits (*)
User should see clear message label like More Details/See Details

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

… Customer see the product details not learn anything"
@m2-assistant
Copy link

m2-assistant bot commented Oct 10, 2020

Hi @Surabhi-Cedcoss. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@surabhisrivastava09 surabhisrivastava09 changed the title #30199 Fixed "Learn More should be See details/More Details as Custom… #30199 Fixed "Learn More should be See details/More Details as Customer see the product details not learn anything" Oct 10, 2020
@vijay-wagento
Copy link

#dmcdindia2020

@rodrigowebjump rodrigowebjump self-requested a review October 10, 2020 06:02
@rodrigowebjump rodrigowebjump self-assigned this Oct 10, 2020
@sivaschenko sivaschenko added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Oct 10, 2020
@ptylek
Copy link
Contributor

ptylek commented Oct 12, 2020

The customer can already click product name or product image to be redirected to PDP. Imo this link's position (below add to cart button) and description is misleading - even with more details it might suggest this is some collapsible and will show more details upon clicking. Maybe it could be removed (I haven't seen this kind of button in shops recently) but this needs more discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Cleanup Component: Catalog Event: dmcdindia2020 Partner: Cedcommerce partners-contribution Pull Request is created by Magento Partner Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: to approve Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Status: To Approve
Development

Successfully merging this pull request may close these issues.

Learn More should be See details/More Details as Customer see the product details not learn anything
6 participants