Bugfix - Payment Method without label position in the array

[andreustimm]

Description (*)

Look at position 14 the Payment Provider may forget the label and this can break the store.

Then, to avoid this bug I put a verification.

Array
(
    [0] => Array
        (
            [value] => 
            [label] => 
        )

    [1] => Array
        (
            [value] => vault
            [label] => 
        )

    [2] => Array
        (
            [value] => mercadopago
            [label] => 
        )

    [3] => Array
        (
            [value] => substitution
            [label] => 
        )

    [4] => Array
        (
            [value] => amazon_payment
            [label] => Amazon Pay
        )

    [5] => Array
        (
            [value] => amazonlogin
            [label] => Amazon Pay
        )

    [6] => Array
        (
            [value] => mercadopago_custom_bank_transfer
            [label] => Bank Transfer - Mercado Pago
        )

    [7] => Array
        (
            [value] => Array
                (
                    [braintree_ach_direct_debit] => Array
                        (
                            [value] => braintree_ach_direct_debit
                            [label] => ACH Direct Debit
                        )

                    [braintree_applepay] => Array
                        (
                            [value] => braintree_applepay
                            [label] => Apple Pay
                        )

                    [braintree] => Array
                        (
                            [value] => braintree
                            [label] => Credit Card
                        )

                    [braintree_googlepay] => Array
                        (
                            [value] => braintree_googlepay
                            [label] => Google Pay
                        )

                    [braintree_local_payment] => Array
                        (
                            [value] => braintree_local_payment
                            [label] => Local Payments
                        )

                    [braintree_paypal] => Array
                        (
                            [value] => braintree_paypal
                            [label] => PayPal
                        )

                    [braintree_paypal_credit] => Array
                        (
                            [value] => braintree_paypal_credit
                            [label] => PayPal Credit
                        )

                    [braintree_paypal_vault] => Array
                        (
                            [value] => braintree_paypal_vault
                            [label] => Stored Accounts (PayPal)
                        )

                    [braintree_cc_vault] => Array
                        (
                            [value] => braintree_cc_vault
                            [label] => Stored Cards
                        )

                    [braintree_venmo] => Array
                        (
                            [value] => braintree_venmo
                            [label] => Venmo
                        )

                )

            [label] => Braintree
        )

    [8] => Array
        (
            [value] => mercadopago_custom
            [label] => Credit Card - Mercado Pago
        )

    [9] => Array
        (
            [label] => Klarna
            [value] => Array
                (
                    [klarna_kp] => Array
                        (
                            [value] => klarna_kp
                            [label] => Klarna Payments
                        )

                )

        )

    [10] => Array
        (
            [value] => Array
                (
                    [banktransfer] => Array
                        (
                            [value] => banktransfer
                            [label] => Bank Transfer Payment
                        )

                    [cashondelivery] => Array
                        (
                            [value] => cashondelivery
                            [label] => Cash On Delivery
                        )

                    [checkmo] => Array
                        (
                            [value] => checkmo
                            [label] => Check / Money order
                        )

                    [free] => Array
                        (
                            [value] => free
                            [label] => No Payment Information Required
                        )

                    [purchaseorder] => Array
                        (
                            [value] => purchaseorder
                            [label] => Purchase Order
                        )

                )

            [label] => Offline Payment Methods
        )

    [11] => Array
        (
            [value] => Array
                (
                    [payflow_advanced] => Array
                        (
                            [value] => payflow_advanced
                            [label] => Credit Card (Payflow Advanced)
                        )

                    [payflow_link] => Array
                        (
                            [value] => payflow_link
                            [label] => Credit Card (Payflow Link)
                        )

                    [payflowpro] => Array
                        (
                            [value] => payflowpro
                            [label] => Credit Card (Payflow Pro)
                        )

                    [paypal_billing_agreement] => Array
                        (
                            [value] => paypal_billing_agreement
                            [label] => PayPal Billing Agreement
                        )

                    [payflow_express_bml] => Array
                        (
                            [value] => payflow_express_bml
                            [label] => PayPal Credit (Payflow Express Bml)
                        )

                    [paypal_express_bml] => Array
                        (
                            [value] => paypal_express_bml
                            [label] => PayPal Credit (Paypal Express Bml)
                        )

                    [paypal_express] => Array
                        (
                            [value] => paypal_express
                            [label] => PayPal Express Checkout
                        )

                    [payflow_express] => Array
                        (
                            [value] => payflow_express
                            [label] => PayPal Express Checkout Payflow Edition
                        )

                    [hosted_pro] => Array
                        (
                            [value] => hosted_pro
                            [label] => Payment by cards or by PayPal account
                        )

                    [payflowpro_cc_vault] => Array
                        (
                            [value] => payflowpro_cc_vault
                            [label] => Stored Cards (Payflow Pro)
                        )
                )
            [label] => PayPal
        )

    [12] => Array
        (
            [value] => mercadopago_basic
            [label] => Quiero pagar con Mercado Pago sin costo Adicional.
        )

    [13] => Array
        (
            [value] => mercadopago_customticket
            [label] => Ticket - Mercado Pago
        )

    [14] => Array
        (
            [value] => Array
                (
                    [pagseguro] => Array
                        (
                            [value] => pagseguro
                            [label] => PagSeguro
                        )
                )
        )
)

Related Pull Requests

No

Manual testing scenarios (*)

Anyone who sends a multiple arrays without a label will break the store, especially in the admin.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Bugfix - Payment Method without label position in the array #30922: Bugfix - Payment Method without label position in the array

[m2-assistant]

Hi @andreustimm. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[sidolov]

@magento create issue

[andreustimm]

This bug is not fixed in 2.4.2 :(

[m2-assistant]

Hi @andreustimm, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[m2-assistant]

Hi @andreustimm. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[gabrieldagama]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.