Skip to content

Clean code less vendor prefix appearance #31191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Dec 7, 2020

Description (*)

Clean code less prefix apperance. Also clear unneccesary prefix flexbox
Flexbox supported widely in all major browsers so we don't need prefix for flexbox anymore
https://caniuse.com/flexbox

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes [Issue] Module & Theme less optimization for cross browser compatibility. #30729
    Rework at closed PR in issue

CC: @ihor-sviziev

Manual testing scenarios (*)

  1. Verify theme admin visual not change compare with before

Questions or comments

Also I have another PR clean code less prefix for flexbox here
#30923

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Clean code less vendor prefix appearance #31193: Clean code less vendor prefix appearance

@m2-assistant
Copy link

m2-assistant bot commented Dec 7, 2020

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Dec 7, 2020
@sidolov
Copy link
Contributor

sidolov commented Dec 7, 2020

@magento create issue

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Dec 24, 2020

@magento run all tests

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Dec 24, 2020

Updated PR as your suggestion

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev
Copy link
Contributor

seems like static tests started to fail

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Dec 24, 2020

hope this one will work!
@magento run all tests

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests EE

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Dec 25, 2020

@magento run WebAPI Tests, Functional Tests B2B

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8586 has been created to process this Pull Request

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Apr 14, 2021

Any new proceed on this

@ihor-sviziev
Copy link
Contributor

@mrtuvn, it's not moving forward because it has p3 priority. Now the only p1 and p2 PRs are getting tested and merged

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Apr 14, 2021

Thank you for clearly information

@mrtuvn mrtuvn marked this pull request as draft March 20, 2023 14:22
@engcom-Bravo
Copy link
Contributor

Hi @mrtuvn,

We are closing this PR.The PR is in Draft since longtime.

Once you are ready Please feel free to reopen it to process the PR further.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Priority: P3 May be fixed according to the position in the backlog. Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
5 participants