-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Clean code less vendor prefix appearance #31191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @mrtuvn. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento create issue |
97c5302
to
b8e5176
Compare
@magento run all tests |
app/design/adminhtml/Magento/backend/Magento_ProductVideo/web/css/source/_module.less
Outdated
Show resolved
Hide resolved
app/design/adminhtml/Magento/backend/Magento_ProductVideo/web/css/source/_module.less
Outdated
Show resolved
Hide resolved
f9712d3
to
765ddb5
Compare
Updated PR as your suggestion |
@magento run all tests |
seems like static tests started to fail |
up UPDATE UP update
765ddb5
to
025e08c
Compare
hope this one will work! |
@magento run Functional Tests EE |
@magento run WebAPI Tests, Functional Tests B2B |
Hi @ihor-sviziev, thank you for the review. |
Any new proceed on this |
@mrtuvn, it's not moving forward because it has p3 priority. Now the only p1 and p2 PRs are getting tested and merged |
Thank you for clearly information |
Hi @mrtuvn, We are closing this PR.The PR is in Draft since longtime. Once you are ready Please feel free to reopen it to process the PR further. Thanks |
Description (*)
Clean code less prefix apperance. Also clear unneccesary prefix flexbox
Flexbox supported widely in all major browsers so we don't need prefix for flexbox anymore
https://caniuse.com/flexbox
Related Pull Requests
Fixed Issues (if relevant)
Rework at closed PR in issue
CC: @ihor-sviziev
Manual testing scenarios (*)
Questions or comments
Also I have another PR clean code less prefix for flexbox here
#30923
Contribution checklist (*)
Resolved issues: