Skip to content

ISSUE-23181: Including new entries for including the weight when creating simple products #31534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

viniciusbordinhao-blueacorn
Copy link
Contributor

Description (*)

Including new entries for including the weight on the step of creating simple products on the admin panel through the configurable product creation page. Before adding these fields when creating simple products using that way, when the configurable product had not a weight assign it has caused the creating of virtual products instead.

With those new fields, the user can assign the weight for the products similar to the way how the quantity and price are assigned.

The user is still capable to ignore the weight when creating the products, however, they will still be created as virtual.

Fixed Issues (if relevant)

  1. Fixes magento/magento2 Configurable - no weight for child products - makes configurable virtual type - no shipping details on checkout #23181

Manual testing scenarios (*)

see #23181

Acceptance tests

app/code/Magento/ConfigurableProduct/Test/Mftf/Test/AdminConfigurableProductCreateTest/AdminConfigurableProductWithWeightCreateTest.xml

app/code/Magento/ConfigurableProduct/Test/Mftf/Test/AdminConfigurableProductCreateTest/AdminConfigurableProductCreateTest.xml

Questions or comments

I was unable to find for myself a way to fix the option available for price and quantity:

  1. Skip the price at this time ;
  2. Skip the quantity at this time.

Skip the weight at this time will keep not assigning a weight for the products, and they will still be created as virtual instead of simple type.

I am opened to any ideas that you can suggest to sort off it.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 4, 2021

Hi @viniciusbordinhao-blueacorn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jan 4, 2021
@viniciusbordinhao-blueacorn
Copy link
Contributor Author

@magento run all tests

@viniciusbordinhao-blueacorn
Copy link
Contributor Author

@magento run all tests

@viniciusbordinhao-blueacorn
Copy link
Contributor Author

@magento run all tests

@viniciusbordinhao-blueacorn
Copy link
Contributor Author

@magento run all tests

@viniciusbordinhao-blueacorn
Copy link
Contributor Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: ConfigurableProduct Partner: Blue Acorn iCi partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants