Skip to content

Fix hard-coded scope store in codebase order model #31986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: 2.4-develop
Choose a base branch
from
Open

Fix hard-coded scope store in codebase order model #31986

wants to merge 8 commits into from

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Feb 8, 2021 •
edited by m2-assistant bot
Loading

Description (*)

Fix hard-coded store value used in code base

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

CC: @ihor-sviziev this one can be merge as quick as possible. Should not break any thing with this change

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix hard-coded scope store in codebase order model #38420: Fix hard-coded scope store in codebase order model

@m2-assistant
Copy link

m2-assistant bot commented Feb 8, 2021

Hi @mrtuvn. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@mrtuvn mrtuvn force-pushed the fix-hardcode-store-scope branch from ef8c6b3 to 511b2c8 Compare February 9, 2021 03:51
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 9, 2021

@magento run all tests

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 9, 2021

@magento run Functional Tests CE, Functional Tests B2B, Functional Tests EE

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 9, 2021

@magento run Functional Tests CE, Functional Tests B2B

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 10, 2021

@magento run Functional Tests B2B

@ihor-sviziev ihor-sviziev added Cleanup Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Feb 17, 2021
@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Feb 17, 2021
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8775 has been created to process this Pull Request
✳️ @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@mrtuvn mrtuvn added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Apr 10, 2021
@mrtuvn mrtuvn marked this pull request as draft March 20, 2023 14:25
@mrtuvn mrtuvn marked this pull request as ready for review January 18, 2024 03:00
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jan 18, 2024

clean code no impact in my opinion. Auto tests may not required for such case

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jan 18, 2024

@magento run all tests

@magento-automated-testing Magento Automated Testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Delta engcom-Delta added Progress: extended testing Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it and removed Progress: extended testing labels Mar 20, 2024
@engcom-November engcom-November self-assigned this Oct 16, 2024
@engcom-November
Copy link
Contributor

@magento run all tests

@engcom-November
Copy link
Contributor

As this PR is related to code refactor to fix hard-coded value, manual testing is not applicable.

SInce there are build failures moving this to Extended testing.

@engcom-November
Copy link
Contributor

@magento run Functional Tests EE

@engcom-November
Copy link
Contributor

There are no repeating failure in Functional Tests EE.

Functional Tests EE:
Part 1:
image

Part 2:
image

Hence moving this to Merge in progress.

@engcom-Dash
Copy link
Contributor

engcom-Dash commented Dec 10, 2024 •
edited
Loading

Moving it back to ET to analyze the build result, as the build URL was not attached in the #31986 (comment) about flaky tests

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Unit Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Unit Tests

@engcom-Dash
Copy link
Contributor

engcom-Dash commented Dec 11, 2024 •
edited
Loading

The functional test failures for B2B, CE, and EE in the last two builds are either inconsistent or related to known issues, and there are open JIRAs for them. The unit test failures are also flaky and have been observed in other PRs(here) as well. These failures are neither related to this PR nor caused by any changes in this PR. Hence moving it to Merge in Progress.

Unit Test:
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31986/53eda656f7998fa63b2baea0374b2a0e/Unit/console-error-logs.html
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31986/5164b0c71ef75fa7ae295f349b97ec40/Unit/console-error-logs.html
image

Functional Tests B2B:
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31986/08881d8c1194122d00942b6e0b44cc1a/Functional/allure-report-b2b/index.html#categories/07f4b257bd008fcbf646b8ae805918a9/6209ad0fdd21fd07/
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31986/a945797707592c03712f6ac1034c431d/Functional/allure-report-b2b/index.html#categories/762df7c18f05a4693d997cb40603bbc2/3c6e9f1af575fa90/

image

Known Issue:
AdminCreateUserRoleWithLimitedPermissionTest: ACQE-6591

Functional Tests CE:
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31986/9862ed952c32a31fcee8eb2e4a8a43b5/Functional/allure-report-ce/index.html
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31986/312b027359265bf8d8ab2b6203d58672/Functional/allure-report-ce/index.html#categories/762df7c18f05a4693d997cb40603bbc2/45ebe1b42280254b/
image

Known Issue:
AdminCreateUserRoleWithLimitedPermissionTest: ACQE-6591

Functional Tests EE:
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31986/d57aed0bb960b36719cdc515de83601b/Functional/allure-report-ee/index.html#categories/b961d4ede0689c2784fd3bd71b12be3c/a3ef0ca50f04cbd4/
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31986/f17f39b140c6f7658299b6c632ae69b0/Functional/allure-report-ee/index.html#categories/762df7c18f05a4693d997cb40603bbc2/695e5aa5a63f4189/
image

Known Issue:
AdminCreateUserRoleWithLimitedPermissionTest: ACQE-6591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4ik Den4ik Den4ik approved these changes

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@Den4ik Den4ik

@ihor-sviziev ihor-sviziev

@engcom-Echo engcom-Echo

@engcom-November engcom-November

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: Sales Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept Release Line: 2.4 Risk: low Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Pull Requests Dashboard
Status: Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Fix hard-coded scope store in codebase order model
8 participants
@mrtuvn @magento-engcom-team @engcom-Delta @engcom-Echo @engcom-November @engcom-Dash @Den4ik @ihor-sviziev