Skip to content

Fixes issue with backorders enabled and qty < 0, is_in_stock = 1 #32366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

duckchip
Copy link
Contributor

@duckchip duckchip commented Mar 4, 2021

Description (*)

This fixes an issue with importing a product that has qty <= 0 and is_in_stock = 1 and Back orders enabled

Fixed Issues (if relevant)

  1. Fixes Import. Simple becomes Out of Stock when it should be in stock because of backorder #32339

Manual testing scenarios (*)

  1. Run csv import with product that has qty <= 0 and is_in_stock = 1 and Back orders enabled
  2. Customer should be able to purchase the product as backorder

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 4, 2021

Hi @duckchip. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@duckchip
Copy link
Contributor Author

duckchip commented Mar 4, 2021

@magento run Integration Tests

@duckchip
Copy link
Contributor Author

duckchip commented Mar 4, 2021

@magento give me test instance

@magento-deployment-service
Copy link

Hi @duckchip. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@duckchip
Copy link
Contributor Author

duckchip commented Mar 4, 2021

@magento give me test instance

@magento-deployment-service
Copy link

Hi @duckchip. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @duckchip, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@gabrieldagama gabrieldagama added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Mar 4, 2021
@duckchip
Copy link
Contributor Author

duckchip commented Mar 5, 2021

@gabrieldagama I think this issue is a bit more important than P4. Note that currently (starting from 2.3.1) it is not possible to import products that should have to possibility to be back-ordered.

Just my thought :))

Thx

@gabrieldagama
Copy link
Contributor

Hi @duckchip, thanks for sharing your thoughts. This priority was agreed during the Public Triage meeting, I understand your point of view. I believe we can set this as P3, but still would be processed after higher priority PRs.

Please consider joining our community triage, we would be happy to discuss it further!

https://github.com/magento/magento2/wiki/Public-Triage-Meeting

Thanks!

@gabrieldagama gabrieldagama added Priority: P3 May be fixed according to the position in the backlog. and removed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. labels Mar 5, 2021
@nuzil
Copy link
Contributor

nuzil commented Mar 5, 2021

@magento run WebAPI Tests

@duckchip
Copy link
Contributor Author

duckchip commented Mar 5, 2021

@magento run Integration Tests

@duckchip
Copy link
Contributor Author

duckchip commented Mar 8, 2021

@magento run all tests

@m2-community-project m2-community-project bot added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label May 20, 2021
@Den4ik
Copy link
Contributor

Den4ik commented May 21, 2021

@duckchip Could you please merge mainline into this PR and fix failed Integration test?

@kandarp26
Copy link
Member

@magento give me test instance

Copy link

Hi @kandarp26. Thank you for your request. I'm working on Magento instance for you.

Copy link

Hi @kandarp26, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CatalogImportExport Priority: P3 May be fixed according to the position in the backlog. Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: review Release Line: 2.4
Projects
Status: Review in Progress
Development

Successfully merging this pull request may close these issues.

Import. Simple becomes Out of Stock when it should be in stock because of backorder
7 participants