Skip to content

Wrong type hint for the protected member $_urlHelper #32496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from
Open

Wrong type hint for the protected member $_urlHelper #32496

wants to merge 2 commits into from

Conversation

HenKun
Copy link

@HenKun HenKun commented Mar 16, 2021 •
edited by m2-assistant bot
Loading

The type hint for the protected member $_urlHelper was wrong.
Undefined class 'Helper':95

Description (*)

Fixes the wrong type hint with the correct one, that is also used in constructor

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

  • Open the file in PHPStorm
  • See the warning

Questions or comments

The issue does not have any negative effect to my knowledge, so this is considred a minor issue.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Wrong type hint for the protected member $_urlHelper #32503: Wrong type hint for the protected member $_urlHelper

@HenKun
Undefined class 'Helper':95
afd62ee 
The type hint for the protected member `$_urlHelper` was wrong.
@m2-assistant
Copy link

m2-assistant bot commented Mar 16, 2021

Hi @HenKun. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@gabrieldagama gabrieldagama added the Priority: P3 May be fixed according to the position in the backlog. label Mar 16, 2021
@gabrieldagama
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Mar 16, 2021
Open
4 tasks
@shikhamis11 shikhamis11 self-requested a review March 18, 2021 12:29
@shikhamis11 shikhamis11 added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Type: Code Cleanup labels Mar 18, 2021
@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11, thank you for the review.
ENGCOM-8939 has been created to process this Pull Request

@shikhamis11
Copy link
Member

@magento run all tests

@shikhamis11
Copy link
Member

@magento run Functional Tests B2B

@shikhamis11
Copy link
Member

@magento run WebAPI Tests

@mrtuvn
Copy link
Contributor

mrtuvn commented Jun 26, 2021

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Delta engcom-Delta self-assigned this Dec 15, 2023
@engcom-Delta
Copy link
Contributor

@magento run all tests

@magento-automated-testing Magento Automated Testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Delta engcom-Delta added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Mar 20, 2024
@engcom-Delta engcom-Delta removed their assignment Mar 20, 2024
@engcom-Dash engcom-Dash self-assigned this Sep 26, 2024
@engcom-Dash
Copy link
Contributor

QA is not required for this change since it only updates the property type to the actual one.

Builds are failing so moving it to extended testing.

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Integration Tests, Functional Tests B2B, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

@magento run Database Compare

@engcom-Dash
Copy link
Contributor

@magento run Integration Tests, Functional Tests B2B, Database Compare

@engcom-Dash
Copy link
Contributor

Integration test failure is different in the last two runs and seems flaky. Hence moving this PR to merge in progress.
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32496/7ca193958c0031b1c14c17d3eef41d45/Integration/console-error-logs.html
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32496/ba87f44ab2dd654a705c8d5580730dcf/Integration/console-error-logs.html
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4ik Den4ik Den4ik approved these changes

@shikhamis11 shikhamis11 shikhamis11 approved these changes

Assignees

@Den4ik Den4ik

@shikhamis11 shikhamis11

@engcom-Dash engcom-Dash

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: Paypal Priority: P3 May be fixed according to the position in the backlog. Progress: ready for testing Release Line: 2.4 Risk: low Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it Type: Code Cleanup
Projects
Pull Requests Dashboard
Status: Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Wrong type hint for the protected member $_urlHelper
8 participants
@HenKun @gabrieldagama @magento-engcom-team @shikhamis11 @mrtuvn @engcom-Delta @engcom-Dash @Den4ik