Skip to content

Js errors when date customer address attribute add to admin customer grid #32975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

dominicfernando
Copy link

@dominicfernando dominicfernando commented May 8, 2021

Description (*)

Steps to reproduce

  • Create date address attribute with below settings.
- type:datetime
- input: date
- is_used_in_grid: 1
- is_visible_in_grid:1
  • Go to admin customer grid
  • Below js issues will show in browser.
knockout.js:3381 Uncaught TypeError: Unable to process binding "text: function(){return $col.getLabel($row()) }"
Message: Cannot read property 'isValid' of undefined
    at UiClass.getLabel (date.js:55)
    at UiClass.getLabel (wrapper.js:109)
    at text (eval at createBindingsStringEvaluator (knockout.js:2982), <anonymous>:3:69)
    at update (knockout.js:4659)
    at ko.dependentObservable.disposeWhenNodeIsRemoved (knockout.js:3373)
    at Function.evaluateImmediate_CallReadThenEndDependencyDetection (knockout.js:2173)
    at Function.evaluateImmediate_CallReadWithDependencyDetection (knockout.js:2140)
    at Function.evaluateImmediate (knockout.js:2101)
    at Object.ko.computed.ko.dependentObservable (knockout.js:1954)
    at knockout.js:3371`

Moment Timezone has no data for false. See http://momentjs.com/timezone/docs/#/data-loading/.

Notes

  • timezone tag type is strings
<column name="dob" ....
            <settings>
                <timezone>false</timezone>
  • moment-timezone-with-data.js -> tz only support strings

- date.tz only support string
- timezone should be string
@m2-assistant
Copy link

m2-assistant bot commented May 8, 2021

Hi @dominicfernando. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@dominicfernando dominicfernando changed the title Js errors in admin customer grid with data customer address attribute Js errors in when date customer address attribute when add to customer grid May 8, 2021
@dominicfernando dominicfernando changed the title Js errors in when date customer address attribute when add to customer grid Js errors when date customer address attribute when add to customer grid May 8, 2021
@dominicfernando dominicfernando changed the title Js errors when date customer address attribute when add to customer grid Js errors when date customer address attribute add to admin customer grid May 8, 2021
@sdzhepa sdzhepa added the Priority: P3 May be fixed according to the position in the backlog. label May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants