Skip to content

Fix variable name in catalogsearch #33533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: 2.4-develop
Choose a base branch
from
Open

Fix variable name in catalogsearch #33533

wants to merge 6 commits into from

Conversation

avoelkl
Copy link
Contributor

@avoelkl avoelkl commented Jul 20, 2021 •
edited by m2-assistant bot
Loading

Fix variable name, the search engine has nothing to do with a default country.
PR Update: I've removed the unneccessary variable. Thanks for the idea @tzyganu ;-)

Description (*)

It's a bit strange and confusing to use a variable called $defaultCountry in the search engine module.
I've renamed removed the variable, there's no change in the behavior/logic of the method.

Fixed Issues (if relevant)

none

Manual testing scenarios (*)

Change Search Engine in the magento admin panel:
Stores > Settings > Configuration > Catalog > Catalog > Catalog Search

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix variable name in catalogsearch #37810: Fix variable name in catalogsearch

@avoelkl
🐛 Rename variable
393f695 
Fix variable name, the search engine has nothing to do with a default country in here
@m2-assistant
Copy link

m2-assistant bot commented Jul 20, 2021

Hi @avoelkl. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@mrtuvn mrtuvn self-assigned this Jul 20, 2021
@mrtuvn
Copy link
Contributor

mrtuvn commented Jul 20, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn mrtuvn added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jul 20, 2021
@avoelkl
🔧 Remove uneccessary variable
41b6911 
Remove variable assignment
@mrtuvn
Copy link
Contributor

mrtuvn commented Jul 20, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik
Den4ik approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@Den4ik Den4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved.

Failed tests is not related to the changes.
But for green builds

@Den4ik
Copy link
Contributor

Den4ik commented Jul 22, 2021

@magento run WebAPI Tests, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik Den4ik added the Priority: P3 May be fixed according to the position in the backlog. label Jul 22, 2021
@magento-engcom-team
Copy link
Contributor

Hi @Den4ik, thank you for the review.
ENGCOM-9158 has been created to process this Pull Request

@engcom-Lima engcom-Lima self-assigned this Jul 21, 2023
@engcom-Lima
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Lima
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jul 28, 2023
Open
5 tasks
@engcom-Lima
Copy link
Contributor

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop and PHP 8.1

Manual testing scenario:

  • Change the Search Engine in the Magento admin panel:Stores > Settings > Configuration > Catalog > Catalog > Catalog Search

After: ✔️
Screenshot 2023-07-28 at 12 30 45 PM
Screenshot 2023-07-28 at 12 54 50 PM

No additional manual test cases are required as part of regression as there are minor changes in the PR.

Builds are failed. Hence, moving this PR to Extended Testing.

@engcom-November
Copy link
Contributor

@magento run all tests

@engcom-November engcom-November self-assigned this Sep 12, 2024
@engcom-November
Copy link
Contributor

@magento run all tests

@engcom-November
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-November
Copy link
Contributor

There are no repeating failures in Functional Tests B2B.

Functional Tests B2B:
Run 1:
image

Run 2:
image

Hence moving this to Merge in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4ik Den4ik Den4ik approved these changes

Assignees

@Den4ik Den4ik

@mrtuvn mrtuvn

@engcom-Lima engcom-Lima

@engcom-November engcom-November

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: CatalogSearch Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Risk: low Type: Code Cleanup
Projects
Pull Requests Dashboard
Status: Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Fix variable name in catalogsearch
7 participants
@avoelkl @mrtuvn @Den4ik @magento-engcom-team @engcom-Lima @engcom-November @engcom-Dash