Skip to content

Reduce async console logger #33850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 11 commits into
base: 2.4-develop
Choose a base branch
from
Draft

Reduce async console logger #33850

wants to merge 11 commits into from
+37 −71

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Aug 18, 2021 •
edited
Loading

Description (*)

path
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Ui/view/base/web/js/lib/logger/console-logger.js
Out of curiousity do we actually need log always load at all page? Should have config allow we on/off load this or exclude it in production ?

Before this changes
Home 187/219 js requests
Category 190/223 js requests
Details 209/250 js requests
Checkout 317/389 js requests

After this changes
Home 178/215 js requests
Category 181/225 js requests
Details 200/247 js requests
Checkout 308/379 js requests

we no longer load around ~10 files. The best scenario not errors we have no longer load additional 10 files. But the worse case. When we got something goes wrong, we need log to indicate what problem and where it happen
Functionals works without affected

No new update since 2017

cc: @VladimirZaets Can you give me some explain or related docs for this. Thanks you

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Reduce async console logger #34385: Reduce async console logger

Sorry, something went wrong.

@m2-assistant
Copy link

m2-assistant bot commented Aug 18, 2021

Hi @mrtuvn. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me platform-health instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

3 similar comments
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

2 similar comments
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn mrtuvn added the Area: Perf/Frontend All tickets related with improving frontend performance. label Aug 31, 2021
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn mrtuvn force-pushed the reduce-console-async-log branch from 05e8bab to a2c8d4b Compare September 4, 2021 09:32
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn mrtuvn changed the base branch from platform-health to 2.4-develop September 6, 2021 01:48
@mrtuvn mrtuvn force-pushed the reduce-console-async-log branch from a2c8d4b to 7573af8 Compare September 6, 2021 02:08
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Sep 6, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Sep 6, 2021

@magento run Functional Tests EE, Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Alfa
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Oct 19, 2021
Open
5 tasks
@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Oct 19, 2021
@mrtuvn mrtuvn marked this pull request as ready for review February 6, 2022 09:02
mrtuvn and others added 3 commits February 6, 2022 01:05
@mrtuvn
Merge branch '2.4-develop' into reduce-console-async-log

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e8f7127
@tuna2smc
Merge branch 'reduce-console-async-log' of https://github.com/mrtuvn/…
11212a7 
…magento2 into reduce-console-async-log
@tuna2smc
Update log console native usages
8e36ee1
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 6, 2022

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 7, 2022

@magento run Functional Tests B2B, Functional Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Merge branch '2.4-develop' into reduce-console-async-log

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
36da159
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Aug 7, 2022

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Aug 7, 2022

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn mrtuvn force-pushed the reduce-console-async-log branch from 9a17e43 to 1385431 Compare October 30, 2022 12:08
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Oct 30, 2022

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Oct 31, 2022

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Nov 20, 2022

https://github.com/magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

mrtuvn added 2 commits February 1, 2023 20:28
@mrtuvn
Update layout.js

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a319399
@mrtuvn
Merge branch '2.4-develop' into reduce-console-async-log

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f7878e8
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 1, 2023

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 2, 2023

@magento run Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 2, 2023

@magento run Integration Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 6, 2023

https://github.com/magento run Functional Tests B2B

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 6, 2023

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Merge branch '2.4-develop' into reduce-console-async-log

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
42df5d8
@mrtuvn mrtuvn marked this pull request as draft March 18, 2023 15:02
ankit-gautam23
ankit-gautam23 approved these changes Apr 21, 2023
View reviewed changes
Copy link

@ankit-gautam23 ankit-gautam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankit-gautam23 ankit-gautam23

Assignees
No one assigned
Labels
Area: Perf/Frontend All tickets related with improving frontend performance. Priority: P3 May be fixed according to the position in the backlog. Progress: pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Reduce async console logger
4 participants
@mrtuvn @engcom-Alfa @ankit-gautam23 @tuna2smc