Bug fix for .lib-button-reset() not resetting text color

[schizek]

Description (*)

Fixed issue where .lib-button-reset() resets the background but not the color.

Corrects issue where button text color does not provide enough contrast on standard background color (i.e. dark buttons with white text reset may present a white text on a white background).

Manual testing scenarios (*)

1. Theme with the following variables set...

@primary__color: @color-black;
@page__background-color: @color-white;
@button__color: @color-white;
@button__background: @color-black;

2. On elements that use the .lib-button-reset() mixin such as the minicart "close" icon, it appears as a white "x" on a white background.

Resolved issues:

1. resolves [Issue] Bug fix for .lib-button-reset() not resetting text color #37900: Bug fix for .lib-button-reset() not resetting text color

[m2-assistant]

Hi @schizek. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[mrtuvn]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[schizek]

Is there something I need to do to debug the "Functional Test CE" that failed?

[mrtuvn]

I think test fails not related with your changes
Can you add some image compare with before/after changes!
Thanks

[mrtuvn]

@magento run Functional Tests CE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[mrtuvn]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[mrtuvn]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[mrtuvn]

changes looks good to me

[mrtuvn]

Looks good to me

[engcom-Lima]

@magento create issue

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@schizek Thank you for collaboration & contribution!

Preconditions:
Install Fresh Magento 2.4-develop

Steps to reproduce:
As mentioned in the PR description
Note : This issue may arrive when the background color and the button color is same. The fix given in PR can reesolve the issue.

✔️ QA Passed

Before: :

PR34445-Before.mov

After: ✔️

PR34445-After.mov

Some of the builds are failing hence moving this PR in Extended Testing.

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Functional Tests B2B

[engcom-Dash]

The consistent test Failure in Functional B2B is a known issue and has JIRA associated with it. Other failures are flaky. They neither part of the PR nor failing because of the PR changes

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/34445/247df88def9b5e13a1b5bd885654d82c/Functional/allure-report-b2b/index.html#categories/e5de0388caf92ef6ef8ca857dbadb7c7/953d9bc4dbe4f3/

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/34445/8d31f4195b51a43565f33e01e6b6a9ee/Functional/allure-report-b2b/index.html#categories

Known Issues: AdminCreateSeparateTemporaryUpdateForBundleProductToChangeChildProductsAssignmentTest ACQE-7821

hence moving this PR to Merge In Progress.