Fix 'magento' adding in the URL when Use Web Server Rewrites set to NO using Console Command #34639
Conversation
…O using Console Command
|
Hi @rmsundar1. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
m2-community-project
bot
added
Priority: P2
|
@magento run all tests |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
| @@ -401,6 +402,9 @@ public function testGetBaseUrlEntryPoint() | |||
| ->willReturnCallback(function ($path, $scope, $scopeCode) use ($expectedPath) { | |||
| return $expectedPath == $path ? 'http://domain.com/' . $path . '/' : null; | |||
| }); | |||
| $this->requestMock->expects($this->once()) | |||
| ->method('getOriginalPathInfo') | |||
| ->willReturn('web/unsecure/base_link_url/test_script.php/'); | |||
There was a problem hiding this comment.
It looks like not a real case. Could you add something similar to what we have during the actual code execution?
| public function testGetBaseUrlFromCli() | ||
| { | ||
| $expectedPath = 'web/unsecure/base_link_url'; | ||
| $expectedBaseUrl = 'http://domain.com/web/unsecure/base_link_url/'; |
There was a problem hiding this comment.
It doesn't look real example. Could you fix that?
m2-community-project
bot
added
Progress: needs update
and removed
Progress: pending review
labels
ihor-sviziev
added
Auto-Tests: Covered
m2-community-project
bot
added
Progress: needs update
and removed
Progress: pending review
labels
|
Please also review and fix test failures |
ihor-sviziev
added
Award: test coverage
and removed
Auto-Tests: Not Required
|
@rmsundar1, could you also provide some info on how both unsecure and secure URLs are configured in the Magento admin? |
|
@magento run all tests |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
|
@magento run all tests |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
1 similar comment
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
|
@magento run all tests |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
|
@magento run all tests |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
1 similar comment
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
|
@magento run Functional Tests B2B, Functional Tests CE |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
2 similar comments
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
|
@magento run Functional Tests B2B, Functional Tests CE |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
|
@magento run Functional Tests CE |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
|
@magento run Functional Tests CE |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Description (*)
Fix 'magento' adding in the URL when Use Web Server Rewrites set to NO using Console Command
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)