Skip to content

34686: fix form key value for toolbar post request #34892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

makzef
Copy link

@makzef makzef commented Dec 28, 2021

Description (*)

Sort direction or pagination count (toolbar) manages by javascript.
This javascript receive cached form key from backend and use it in POST request.
This PR change the behaaviour to grab form key that stored in cookies instead of cached one.

Related Pull Requests

The similar issue was already fixed. Used the experience of this PR to fix this issue.

  1. MC-30171: Add to Cart Form wrong Form Key in FPC #30961

Fixed Issues (if relevant)

  1. Fixes Invalid Form Key on catalog sorting when Remember Category Pagination and cache are enabled #34686

Manual testing scenarios (*)

Manual testing was proceed according to reproduce steps.
Notice: FPS and Remember Category Pagination option were enabled.

  1. Visit any category page that contain products.
  2. Remove cookies (or use incognito mode) and visit the same category page again.
  3. Try to change product list direction or order or try to change pagination count.
  4. Check the correct form key was used and there are no related errors on catalog page.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Sorry, something went wrong.

@m2-assistant
Copy link

m2-assistant bot commented Dec 28, 2021

Hi @makzef. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@makzef
Copy link
Author

makzef commented Dec 28, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@makzef
Copy link
Author

makzef commented Dec 30, 2021

@magento run Unit Tests, Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@makzef
Copy link
Author

makzef commented Jan 3, 2022

@magento run Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@coderimus coderimus self-requested a review January 12, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Form Key on catalog sorting when Remember Category Pagination and cache are enabled
2 participants