Skip to content

Issue 35088 #35089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
$_category = $block->getCurrentCategory();
$_imgHtml = '';
if ($_imgUrl = $block->getImage()->getUrl($_category)) {
if(file_exists($_imgUrl)) {
$_imgHtml = '<div class="category-image"><img src="'
. $block->escapeUrl($_imgUrl)
. '" alt="'
Expand All @@ -28,5 +29,6 @@
. '" class="image" /></div>';
$_imgHtml = $block->getOutput()->categoryAttribute($_category, $_imgHtml, 'image');
/* @noEscape */ echo $_imgHtml;
}
}
?>
204 changes: 204 additions & 0 deletions lib/internal/Magento/Framework/Data/Form/Element/Datetime.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,204 @@
<?php
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/

/**
* Magento data selector form element
*
* @author Magento Core Team <core@magentocommerce.com>
*/

namespace Magento\Framework\Data\Form\Element;

use Magento\Framework\Escaper;
use Magento\Framework\Stdlib\DateTime\TimezoneInterface;

/**
* Date element
*/
class Datetime extends AbstractElement
{
/**
* @var \DateTime
*/
protected $_value;

/**
* @var TimezoneInterface
*/
protected $localeDate;

/**
* @param Factory $factoryElement
* @param CollectionFactory $factoryCollection
* @param Escaper $escaper
* @param TimezoneInterface $localeDate
* @param array $data
*/
public function __construct(
Factory $factoryElement,
CollectionFactory $factoryCollection,
Escaper $escaper,
TimezoneInterface $localeDate,
$data = []
) {
$this->localeDate = $localeDate;
parent::__construct($factoryElement, $factoryCollection, $escaper, $data);
$this->setType('text');
$this->setExtType('textfield');
if (isset($data['value'])) {
$this->setValue($data['value']);
}
}

/**
* Check if a string is a date value
*
* @param string $value
* @return bool
*/
private function isDate(string $value): bool
{
$date = date_parse($value);

return !empty($date['year']) && !empty($date['month']) && !empty($date['day']);
}

/**
* If script executes on x64 system, converts large numeric values to timestamp limit
*
* @param int $value
* @return int
*/
protected function _toTimestamp($value)
{
$value = (int)$value;
if ($value > 3155760000) {
$value = 0;
}

return $value;
}

/**
* Set date value
*
* @param mixed $value
* @return $this
*/
public function setValue($value)
{
if (empty($value)) {
$this->_value = '';
return $this;
}
if ($value instanceof \DateTimeInterface) {
$this->_value = $value;
return $this;
}
try {
if (preg_match('/^[0-9]+$/', $value)) {
$this->_value = (new \DateTime())->setTimestamp($this->_toTimestamp($value));
} elseif (is_string($value) && $this->isDate($value)) {
$this->_value = new \DateTime($value, new \DateTimeZone($this->localeDate->getConfigTimezone()));
} else {
$this->_value = '';
}
} catch (\Exception $e) {
$this->_value = '';
}
return $this;
}

/**
* Get date value as string.
*
* Format can be specified, or it will be taken from $this->getFormat()
*
* @param string $format (compatible with \DateTime)
* @return string
*/
public function getValue($format = null)
{
if (empty($this->_value)) {
return '';
}
if (null === $format) {
$format = $this->getDateFormat();
$format .= ($format && $this->getTimeFormat()) ? ' ' : '';
$format .= $this->getTimeFormat() ? $this->getTimeFormat() : '';
}
return $this->localeDate->formatDateTime(
$this->_value,
null,
null,
null,
$this->_value->getTimezone(),
$format
);
}

/**
* Get value instance, if any
*
* @return \DateTime
*/
public function getValueInstance()
{
if (empty($this->_value)) {
return null;
}
return $this->_value;
}

/**
* Output the input field and assign calendar instance to it.
* In order to output the date:
* - the value must be instantiated (\DateTime)
* - output format must be set (compatible with \DateTime)
*
* @throws \Exception
* @return string
*/
public function getElementHtml()
{
$this->addClass('admin__control-text input-text input-date');
$dateFormat = $this->getDateFormat() ?: $this->getFormat();
$dateFormat = 'mm/dd/yy';
$timeFormat = $this->getTimeFormat();
if (empty($dateFormat)) {
throw new \Exception(
'Output format is not specified. ' .
'Please specify "format" key in constructor, or set it using setFormat().'
);
}

$dataInit = 'data-mage-init="' . $this->_escape(
json_encode(
[
'calendar' => [
'dateFormat' => $dateFormat,
'showsTime' => true,
'timeFormat' => 'HH:mm',
'buttonImage' => $this->getImage(),
'buttonText' => 'Select Date',
'changeYear' => true,
],
]
)
) . '"';

$html = sprintf(
'<input name="%s" id="%s" value="%s" %s %s />',
$this->getName(),
$this->getHtmlId(),
$this->_escape($this->getValue()),
$this->serialize($this->getHtmlAttributes()),
$dataInit
);
$html .= $this->getAfterElementHtml();
return $html;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ class Factory
'checkboxes',
'column',
'date',
'datetime',
'editablemultiselect',
'editor',
'fieldset',
Expand Down