Skip to content

Chore: Import Export - Replace Block Escaping with Escaper #37069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Chore: Import Export - Replace Block Escaping with Escaper #37069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions app/code/Magento/ImportExport/view/adminhtml/templates/busy.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,19 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
declare(strict_types=1);

use Magento\Framework\Escaper;

/** @var Escaper $escaper */
?>
<div class="fieldset">
<div class="legend">
<span><?= $block->escapeHtml(__('Status')) ?></span>
<span><?= $escaper->escapeHtml(__('Status')) ?></span>
</div><br>
<div class="messages">
<div class="message message-success success">
<div><?= $block->escapeHtml($block->getStatusMessage()) ?></div>
<div><?= $escaper->escapeHtml($block->getStatusMessage()) ?></div>
</div>
</div>
</div>
16 changes: 11 additions & 5 deletions app/code/Magento/ImportExport/view/adminhtml/templates/export/form/after.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,27 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
declare(strict_types=1);

/** @var \Magento\ImportExport\Block\Adminhtml\Form\After $block */
/** @var \Magento\Framework\View\Helper\SecureHtmlRenderer $secureRenderer */
use Magento\Framework\Escaper;
use Magento\Framework\View\Helper\SecureHtmlRenderer;
use Magento\ImportExport\Block\Adminhtml\Form\After;

/** @var Escaper $escaper */
/** @var After $block */
/** @var SecureHtmlRenderer $secureRenderer */
?>
<fieldset class="admin__fieldset" id="export_filter_container">
<legend class="admin__legend">
<span><?= $block->escapeHtml(__('Entity Attributes')) ?></span>
<span><?= $escaper->escapeHtml(__('Entity Attributes')) ?></span>
</legend>
<br />
<form id="export_filter_form" action="<?= $block->escapeUrl($block->getUrl('*/*/export')) ?>" method="post">
<form id="export_filter_form" action="<?= $escaper->escapeUrl($block->getUrl('*/*/export')) ?>" method="post">
<input name="form_key" type="hidden" value="<?= /* @noEscape */ $block->getFormKey() ?>" />
<div id="export_filter_grid_container"><!-- --></div>
</form>
<button class="action- scalable" type="button">
<span><?= $block->escapeHtml(__('Continue')) ?></span>
<span><?= $escaper->escapeHtml(__('Continue')) ?></span>
</button>
</fieldset>
<?= /* @noEscape */ $secureRenderer->renderStyleAsTag("display:none;", 'fieldset#export_filter_container') ?>
Expand Down
17 changes: 11 additions & 6 deletions app/code/Magento/ImportExport/view/adminhtml/templates/export/form/before.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,17 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
declare(strict_types=1);

/** @var \Magento\Backend\Block\Template $block */
/** @var \Magento\Framework\View\Helper\SecureHtmlRenderer $secureRenderer */
?>
use Magento\Backend\Block\Template;
use Magento\Framework\Escaper;
use Magento\Framework\View\Helper\SecureHtmlRenderer;

/** @var Escaper $escaper */
/** @var Template $block */
/** @var SecureHtmlRenderer $secureRenderer */

<?php $scriptString = <<<script
$scriptString = <<<script
require([
'Magento_Ui/js/modal/alert',
'prototype'
Expand Down Expand Up @@ -48,7 +53,7 @@ require([
*/
getFilter: function() {
if ($('entity') && \$F('entity')) {
var url = "{$block->escapeJs($block->getUrl('*/*/getFilter'))}";
var url = "{$escaper->escapeJs($block->getUrl('*/*/getFilter'))}";
var entity = \$F('entity');
if (entity != this.previousGridEntity) {
this.previousGridEntity = entity;
Expand Down Expand Up @@ -93,7 +98,7 @@ require([
form.action = oldAction;
} else {
alert({
content: '{$block->escapeHtml(__('Invalid data'))}'
content: '{$escaper->escapeHtml(__('Invalid data'))}'
});
}
};
Expand Down
13 changes: 9 additions & 4 deletions app/code/Magento/ImportExport/view/adminhtml/templates/import/form/after.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,20 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
declare(strict_types=1);

/** @var \Magento\ImportExport\Block\Adminhtml\Form\After $block */
/** @var \Magento\Framework\View\Helper\SecureHtmlRenderer $secureRenderer */
?>
use Magento\Framework\Escaper;
use Magento\Framework\View\Helper\SecureHtmlRenderer;
use Magento\ImportExport\Block\Adminhtml\Form\After;

/** @var Escaper $escaper */
/** @var After $block */
/** @var SecureHtmlRenderer $secureRenderer */
?>
<div class="entry-edit fieldset" id="import_validation_container">
<div class="entry-edit-head legend">
<span class="icon-head head-edit-form fieldset-legend"
id="import_validation_container_header"><?= $block->escapeHtml(__('Validation Results')) ?></span>
id="import_validation_container_header"><?= $escaper->escapeHtml(__('Validation Results')) ?></span>
</div><br>
<div id="import_validation_messages" class="fieldset"><!-- --></div>
</div>
Expand Down
19 changes: 12 additions & 7 deletions app/code/Magento/ImportExport/view/adminhtml/templates/import/form/before.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,17 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
?>
<?php
/** @var $block \Magento\ImportExport\Block\Adminhtml\Import\Edit\Before */
/** @var \Magento\Framework\View\Helper\SecureHtmlRenderer $secureRenderer */
declare(strict_types=1);

use Magento\Framework\Escaper;
use Magento\Framework\View\Helper\SecureHtmlRenderer;
use Magento\ImportExport\Block\Adminhtml\Import\Edit\Before;

/** @var Escaper $escaper */
/** @var Before $block */
/** @var SecureHtmlRenderer $secureRenderer */
$fieldNameSourceFile = \Magento\ImportExport\Model\Import::FIELD_NAME_SOURCE_FILE;
$uploaderErrorMessage = $block->escapeHtml(
$uploaderErrorMessage = $escaper->escapeHtml(
__('Content of uploaded file was changed, please re-upload the file')
);
?>
Expand Down Expand Up @@ -51,7 +56,7 @@ require([
* Base url
* @type {string}
*/
sampleFilesBaseUrl: '{$block->escapeJs($block->getUrl('*/*/download/', ['filename' => 'entity-name']))}',
sampleFilesBaseUrl: '{$escaper->escapeJs($block->getUrl('*/*/download/', ['filename' => 'entity-name']))}',

/**
* Loaded file last modified
Expand Down Expand Up @@ -258,7 +263,7 @@ require([
postToFrameProcessResponse: function(response) {
if ('object' != typeof(response)) {
alert({
content: '{$block->escapeHtml(__('Invalid response'))}'
content: '{$escaper->escapeHtml(__('Invalid response'))}'
});

return false;
Expand Down