Skip to content

[AC-8699] Magento Pages Width does not match anymore for Long width c… #37476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: 2.4-develop
Choose a base branch
from
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -42,6 +42,7 @@
margin-bottom: 2rem;
max-width: 100%;
padding-bottom: 1rem;
overflow-x: auto;
padding-top: @data-grid-header-row__indent;
overflow-x: auto
}
@@ -430,7 +431,7 @@ body._in-resize {
.data-grid-actions-cell {
padding-left: @data-grid-cell__padding-horizontal * 2;
padding-right: @data-grid-cell__padding-horizontal * 2;
position: relative;
position: inherit;
text-align: center;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason of this update position

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it's work without it ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @adamphh can you explain more about this changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no specific or special reason i suggest to remove for reduce extra css property

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrtuvn there is no special reason for that, it can work without position, However I am not sure if it affect to another section.

width: 1%;
}