Skip to content

All merge commit #38945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: 2.4-develop
Choose a base branch
from
Open

Conversation

Shivam7-1
Copy link
Contributor

Description (*)

According this #38836 (comment) I had Merged All My Contribution Commit to here

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Jul 18, 2024

Hi @Shivam7-1. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jul 23, 2024
@Shivam7-1
Copy link
Contributor Author

Hi @engcom-Hotel
Is there Any Thing else is Required From My Side?

Because PR is Not Yet Merged
Earlier seperate PR's has been Verified and check also
Regards

@Shivam7-1
Copy link
Contributor Author

Hi @engcom-Hotel
Is there Any Thing else is Required From My Side?

Because PR is Not Yet Merged
Earlier seperate PR's has been Verified and check also
Regards

@engcom-Hotel
Copy link
Contributor

Hello @Shivam7-1,

Currently, we are focusing on the PRs from the below board:

https://github.com/magento/magento2/projects/23?card_filter_query=no%3Aassignee

This board contains highly upvoted PRs. We will make sure to pick this PR accordingly.

Thanks

@Shivam7-1
Copy link
Contributor Author

Hi @engcom-Hotel
Is there Any Thing else is Required From My Side?

Because PR is Not Yet Merged
Earlier seperate PR's has been Verified and check also
Regards

1 similar comment
@Shivam7-1
Copy link
Contributor Author

Hi @engcom-Hotel
Is there Any Thing else is Required From My Side?

Because PR is Not Yet Merged
Earlier seperate PR's has been Verified and check also
Regards

@engcom-Hotel
Copy link
Contributor

Hello @Shivam7-1,

Please refer to my comment here. We will pick this as per the priority.

Thanks

@Shivam7-1
Copy link
Contributor Author

Hii @engcom-Hotel
Could you please Review this PR as it is pending for review from many months

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants