Skip to content

Update subtotal.phtml #39612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

vkrokh
Copy link

@vkrokh vkrokh commented Feb 10, 2025

Typo at checkout subtotal

image

Resolved issues:

  1. resolves [Issue] Update subtotal.phtml #39619: Update subtotal.phtml

Copy link

m2-assistant bot commented Feb 10, 2025

Hi @vkrokh. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Feb 11, 2025
@engcom-Hotel
Copy link
Contributor

@magento create issue

@engcom-Charlie engcom-Charlie added the Project: Community Picked PRs upvoted by the community label Apr 10, 2025
@engcom-Charlie engcom-Charlie moved this to Ready for Testing in Community Dashboard Apr 10, 2025
@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in Community Dashboard Apr 10, 2025
@engcom-Bravo
Copy link
Contributor

@magento run all tests

@engcom-Bravo
Copy link
Contributor

Hi @vkrokh,

Thanks for the collaboration & contribution!

✔️ QA Passed

Thanks.

@engcom-Bravo engcom-Bravo moved this from Testing in Progress to Extended testing (optional) in Community Dashboard Apr 10, 2025
@engcom-Dash engcom-Dash self-assigned this Apr 11, 2025
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests B2B, Static Tests, WebAPI Tests

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

@engcom-Dash
Copy link
Contributor

engcom-Dash commented Apr 14, 2025

Test failures for Functional EE are inconsistent and seems to be flaky. They neither part of PR nor failing because of the PR changes.

Build 1: Allure-Report-EE

image

Build 2: Allure-Report-EE

image

@ihor-sviziev & @engcom-Hotel As, I have fixed the static failures, requesting you for a review so that we can proceed further on this PR. Please let me know anything else needed.

Thank You!

@engcom-Dash engcom-Dash moved this from Extended testing (optional) to Merge in Progress in Community Dashboard Apr 14, 2025
@engcom-Dash engcom-Dash moved this from Merge in Progress to Extended testing (optional) in Community Dashboard Apr 14, 2025
@engcom-Dash engcom-Dash moved this from Extended testing (optional) to Pending Review in Community Dashboard Apr 14, 2025
@engcom-Dash
Copy link
Contributor

@engcom-Hotel Thank you for reviewing the PR changes. Moving this PR in Merge In Progress as the changes are approved and the ET is already done.

@engcom-Dash engcom-Dash moved this from Ready for Testing to Merge in Progress in Community Dashboard Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing Project: Community Picked PRs upvoted by the community
Projects
Status: Merge in Progress
Development

Successfully merging this pull request may close these issues.

[Issue] Update subtotal.phtml
6 participants