magento/magento2#35371: Product page gives error because of url rewrites

[Himsoft]

Description (*)

In situation when category with level > 2 have product url key at the beginning of its url key, str_replace(), used in \Magento\CatalogUrlRewrite\Model\Storage\DynamicStorage::findProductRewriteByRequestPath, replaces all parts of the category path equal to the product url key.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Product page gives error because of url rewrites #35371

Manual testing scenarios (*)

1. Stores -> Configuration -> Catalog -> Catalog -> Search Engine Optimization -> Product URL Suffix is empty.
2. Stores -> Configuration -> Catalog -> Catalog -> Search Engine Optimization -> Category URL Suffix is empty.
3. Stores -> Configuration -> Catalog -> Catalog -> Search Engine Optimization -> Use Categories Path For Product URLs is Yes.
4. Stores -> Configuration -> Catalog -> Catalog -> Search Engine Optimization -> Generate "category/product" URL Rewrites is No.
5. Create new category with name Test Category under root category (Catalog - Categories)
6. Create sub category with name Test Sub Category under new category and save (Catalog - Categories)
7. Create Product with name Test and assigned only new sub category and save
8. Go to Test Sub Category.
9. Click on product Test.

Before fix:
There is 404 error.

After fix:
The product page is loaded successfully.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Himsoft. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[Himsoft]

@magento run all tests

[Himsoft]

@magento run all tests

[Himsoft]

@magento run all tests

[Himsoft]

@magento run Functional Tests B2B

[Himsoft]

@magento run Functional Tests B2B

[Himsoft]

The failed tests are not related to fixes, they look like false positives, please pay attention to this during the review.

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @Himsoft,

Thank you for your contribution!

Please make the changes as per the below review comment, also add appropriate test data in its file to satisfy the PR changes.

Thanks

[engcom-Hotel]

It must be 2019, as the file has been created in this year only.

[Himsoft]

@magento run all tests

[engcom-Dash]

@Himsoft Thank you for the contribution!
Are you working on the test data changes mentioned in the review-comment to satisfy the PR changes ?

[engcom-Dash]

@magento run all tests

[Himsoft]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@engcom-Hotel The test data changes has been added by @Himsoft. Also, I have fixed some of the failing static test cases. Hence Moving this PR to Pending Review.

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

[engcom-Bravo]

Hi @Himsoft,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Steps to reproduce

• Stores -> Configuration -> Catalog -> Catalog -> Search Engine Optimization -> Product URL Suffix is empty.
• Stores -> Configuration -> Catalog -> Catalog -> Search Engine Optimization -> Category URL Suffix is empty.
• Stores -> Configuration -> Catalog -> Catalog -> Search Engine Optimization -> Use Categories Path For Product URLs is Yes.
• Stores -> Configuration -> Catalog -> Catalog -> Search Engine Optimization -> Generate "category/product" URL Rewrites is No.
• Create new category with name Test Category under root category (Catalog - Categories)
• Create sub category with name Test Sub Category under new category and save (Catalog - Categories)
• Create Product with name Test and assigned only new sub category and save
• Go to Test Sub Category.
• Click on product Test.

Before: ✖️ 

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

[engcom-Charlie]

@magento run Functional Tests B2B, Functional Tests CE

[engcom-Charlie]

The Functional B2B failures in recent 2 builds are not consistent. They are neither part of this PR nor failing because of the PR changes, seems to be flaky. Hence moving the PR to Merge in Progress.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39670/679313557e07da76758e73510bff5861/Functional/allure-report-b2b/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39670/e32d481670eba1686c75e2a87619f822/Functional/allure-report-b2b/index.html#categories/bdbf199525818fae7a8651db9eafe741