Skip to content

magento/magento2#39169: Special Price To Date is wrongly validated on applySpecialPrice #39690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: 2.4-develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions app/code/Magento/Catalog/Pricing/Price/SpecialPrice.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2015 Adobe
* All Rights Reserved.
*/

namespace Magento\Catalog\Pricing\Price;
Expand Down Expand Up @@ -103,10 +103,16 @@ public function getSpecialToDate()
*/
public function isScopeDateInInterval()
{
$dateTo = $this->getSpecialToDate();
if ($dateTo && date('H:i:s', strtotime($dateTo)) !== '00:00:00') {
$dateToTimestamp = strtotime($dateTo);
$dateTo = date('Y-m-d H:i:s', $dateToTimestamp - 86400);
}

return $this->localeDate->isScopeDateInInterval(
WebsiteInterface::ADMIN_CODE,
$this->getSpecialFromDate(),
$this->getSpecialToDate()
$dateTo
);
}

Expand Down
4 changes: 2 additions & 2 deletions lib/internal/Magento/Framework/Stdlib/DateTime/Timezone.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2015 Adobe
* All Rights Reserved.
*/

namespace Magento\Framework\Stdlib\DateTime;
Expand Down