Skip to content

Issue-39692 Widget Block Selection issue fix - If block have same identifier #39722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

Mohamed-Asar
Copy link
Contributor

Description (*)

Used block id for widget_parameters instead of block identifier, allowing users to configure blocks with the same identifier across multiple store views.

Fixed Issues (if relevant)

  1. Fixes Block selection in widgets that have the same identifier #39692

Manual testing scenarios (*)

  1. Create Two Store Views.
  2. Create Two CMS Blocks, one for each store view, using the same identifier.
  3. Create Two Widgets, one for each store view, and assign the respective CMS blocks.
  4. The corresponding CMS block should be displayed in the widget for each store view.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Mar 8, 2025

Hi @Mohamed-Asar. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Mar 8, 2025
@Mohamed-Asar
Copy link
Contributor Author

@magento run all tests

@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 10, 2025
@Mohamed-Asar
Copy link
Contributor Author

@magento run all tests

@engcom-Charlie engcom-Charlie moved this to Pending Review in Community Dashboard Apr 10, 2025
@engcom-Charlie engcom-Charlie added the Project: Community Picked PRs upvoted by the community label Apr 10, 2025
@Mohamed-Asar
Copy link
Contributor Author

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel engcom-Hotel self-requested a review April 16, 2025 09:56
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Pending Review to Review in Progress in Community Dashboard Apr 16, 2025
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Mohamed-Asar,

Thanks for the contribution!

I guess some of the Functional tests are failing due to the code changes. Please have a look on it.

Thanks

@Mohamed-Asar
Copy link
Contributor Author

@engcom-Hotel Sure i will check and fix the Functional test issues

@Mohamed-Asar
Copy link
Contributor Author

@magento run all tests

@Mohamed-Asar
Copy link
Contributor Author

@magento run all tests

@Mohamed-Asar
Copy link
Contributor Author

Hi @engcom-Hotel

I fixed the functional test case which is related to this ticket, please review

@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Review in Progress to Ready for Testing in Community Dashboard Apr 17, 2025
@engcom-Bravo engcom-Bravo self-assigned this Apr 21, 2025
@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in Community Dashboard Apr 21, 2025
@engcom-Bravo
Copy link
Contributor

@magento run all tests

@engcom-Bravo
Copy link
Contributor

Hi @Mohamed-Asar,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  • Create Two Store Views.
  • Create Two CMS Blocks, one for each store view, using the same identifier.
  • Create Two Widgets, one for each store view, and assign the respective CMS blocks.
  • The corresponding CMS block should be displayed in the widget for each store view.

Before: ✖️ 

Screenshot 2025-04-21 at 3 09 57 pm Screenshot 2025-04-21 at 3 10 05 pm

After: ✔️

Screenshot 2025-04-21 at 3 17 38 pm

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Bravo engcom-Bravo moved this from Testing in Progress to Extended testing (optional) in Community Dashboard Apr 21, 2025
@engcom-Charlie engcom-Charlie self-assigned this Apr 23, 2025
@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE

@engcom-Charlie engcom-Charlie moved this from Extended testing (optional) to Merge in Progress in Community Dashboard Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Project: Community Picked PRs upvoted by the community
Projects
Status: Merge in Progress
Development

Successfully merging this pull request may close these issues.

Block selection in widgets that have the same identifier
5 participants