-
Notifications
You must be signed in to change notification settings - Fork 4
Add bin folder to python targets, and adapt the regular python layout (save for the zip). #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
956dd1a
to
aa90fdb
Compare
889af7f
to
d068625
Compare
uses: actions/upload-artifact@v4 | ||
with: | ||
name: godot-python-${{ matrix.platform }}-${{ matrix.arch }} | ||
path: bin/**/* | ||
path: godot-python-${{ matrix.platform }}-${{ matrix.arch }}.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping providing a single path would make it upload the file as-is, but it's still zipping the zip. Need to find a better way.
Questions:
|
Linux build is broken with this:
Probably due to moving
Not sure how I feel about setting all sorts of RPATHs on all platforms... Need to test Python extension modules, as well as Windows. Need to find a layout and dynamic linking config that will be simple and work reliably on all platforms. Incorrect dynamic linking is blocking for any patch. Maybe a test could be made to run after the GitHub build actions. |
… (save for the zip). Use the zip upload archive method in the github runner for macOS, too, to preserve permissions.
d068625
to
7dfeeb2
Compare
No, at least not for me, why would it?
Nope, I don't have any other systems on hand.
Nothing really. It has been working as expected so far.
What do you mean by 'python config'? It's using the python executable that are part of the indygreg standalone builds.
Hrm, I'm not sure I understand what you are asking here. Would you mind explaining?
I definitely think so. Using this approach,
|
Considering this blocked until #44 is resolved. |
Addresses #19. We should probably document this (and / or make it simpler), but this is a good start.
This allows godot-python users to use python (and pip) out of the box:
The python binary points to
@executable_path/../lib/libpython3.12.dylib
so it's already configured correctly with this new layout (i.e. python lib moved topython/lib
).The bin folder is
.gdignore
'd.