Skip to content

Add custom annotation to the map. #4704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add custom annotation to the map. #4704

wants to merge 2 commits into from

Conversation

toshanmugaraj
Copy link

element-hq/element-web#29223

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • [ x] Linter and other CI checks pass.
  • [x ] Sign-off given on the changes (see CONTRIBUTING.md).

@toshanmugaraj toshanmugaraj requested a review from a team as a code owner February 10, 2025 05:28
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Feb 10, 2025
@dbkr
Copy link
Member

dbkr commented Feb 10, 2025

What is this implementing? I don't see m.room.annotation anywhere in the spec.

@richvdh
Copy link
Member

richvdh commented Feb 21, 2025

This doesn't seem to be a coherent addition to the SDK as it stands.

@richvdh richvdh closed this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toshanmugaraj @dbkr @richvdh