-
Notifications
You must be signed in to change notification settings - Fork 124
Improve error logs related to invalid source url in model generation #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…odel Signed-off-by: Riya Garg <riyag1452003@gmail.com>
Warning You have reached your daily quota limit. As a reminder, free tier users are limited to 5 requests per day. Please wait up to 24 hours and I will start processing your requests again! |
@riyaa14, thank you. This is an improvement. 🙂 From the looks of it, it seems that we can be more accurate with the suggested probable cause. At the point in time in our logic where we are unable to retrieve the latest release tag, it should be the case that we've already been able to reach the URL that the user has provided and have moved along in our logic to looking up the release tag. If this is true, suggesting that the #1 most probable cause is an invalid source URL is inaccurate, and not helpful to users resolving this issue, then retrying and being successful. Here is the URL that I used when I received this error: git://github.com/Azure/azure-service-operator/blob/main/charts/azure-service-operator-1.9.0.tgz. Be a user. Try using this URL to create a model. When you get a failure message. What are you to do with the information provided in the Suggested Remediation?
@riyaa14, this discussion is still on the topic of our very first assignment: documentation of the various scenarios in which Let's be discerning with our event notifications, ensuring that we are offering information back to the user at each step and specific to each step of the generation process. @FaheemOnHub, where is the updated contributing docs on custom event notification formats? All events should include a link to a docs page, @riyaa14 @lekaf974 @alphaX86 @hexxdump. // @zihanKuang The list of scenarios you've fathomed are now documented in the Meshery Test Plan spreadsheet as test cases, I think (awesome!). Please, please put your user hat on and attempt to use the Import Model and Create Model wizards - - with no assumption of prior knowledge. How can we improve? What doesn't make sense? These need reconciled and improved:
|
Signed-off-by: Riya Garg <riyag1452003@gmail.com>
Signed-off-by: Riya Garg <96983874+riyaa14@users.noreply.github.com>
Description
This PR fixes #
Before
Test 1: GitHub repo with no releases & Test 2: Private GitHub repository
Test 3: Invalid source URL format, with
blob
in its URL, thus couldn't read the filesAfter
Test 1: GitHub repo with no releases & Test 2: Private GitHub repository
Test 3: Invalid source URL format, with
blob
in its URL, thus couldn't read the filesNotes for Reviewers
Signed commits
TO DO