[#6889] CQA to support TokenCredential instead of key

[sw-joelmut]

Fixes #6889

Description

This PR adds the ability to use a Managed Identity ClientId to authenticate to the Language service.

Specific Changes

• Added QuestionAnswering and Azure.Identity packages
• Updated/Added constructors to receive the Managed Identity ClientId.
• Updated GetAnswers and AddFeedback methods to match the new QuestionAnswering package.

Testing

The following images show the GetAnswers and AddFeedback functionalities working with the existing EndpointKey and the new MSI ClientId.

[tracyboehrer]

Getting this on build:

tests\Microsoft.Bot.Builder.AI.QnA.Tests\LanguageServiceTests.cs(1103,21): Error CS0121: The call is ambiguous between the following methods or properties: 'CustomQuestionAnswering.CustomQuestionAnswering(QnAMakerEndpoint, QnAMakerOptions, HttpClient)' and 'CustomQuestionAnswering.CustomQuestionAnswering(QnAMakerEndpoint, IBotTelemetryClient, bool, HttpClient)'Build • Debug_Windows_Configuration_8 • Build solution Microsoft.Bot.Builder.sln |   |   -- | -- | --   | tests\Microsoft.Bot.Builder.AI.QnA.Tests\LanguageServiceTests.cs(1153,56): Error CS0121: The call is ambiguous between the following methods or properties: 'CustomQuestionAnswering.CustomQuestionAnswering(QnAMakerEndpoint, QnAMakerOptions, HttpClient)' and 'CustomQuestionAnswering.CustomQuestionAnswering(QnAMakerEndpoint, IBotTelemetryClient, bool, HttpClient)'Build • Debug_Windows_Configuration_8 • Build solution Microsoft.Bot.Builder.sln |   |     | tests\Microsoft.Bot.Builder.AI.QnA.Tests\LanguageServiceTests.cs(1171,56): Error CS0121: The call is ambiguous between the following methods or properties: 'CustomQuestionAnswering.CustomQuestionAnswering(QnAMakerEndpoint, QnAMakerOptions, HttpClient)' and 'CustomQuestionAnswering.CustomQuestionAnswering(QnAMakerEndpoint, IBotTelemetryClient, bool, HttpClient)'Build • Debug_Windows_Configuration_8 • Build solution Microsoft.Bot.Builder.sln |   |     | tests\Microsoft.Bot.Builder.AI.QnA.Tests\LanguageServiceTests.cs(1291,27): Error CS0121: The call is ambiguous between the following methods or properties: 'CustomQuestionAnswering.CustomQuestionAnswering(QnAMakerEndpoint, QnAMakerOptions, HttpClient)' and 'CustomQuestionAnswering.CustomQuestionAnswering(QnAMakerEndpoint, IBotTelemetryClient, bool, HttpClient)'Build • Debug_Windows_Configuration_8 • Build solution Microsoft.Bot.Builder.sln |   |     | tests\Microsoft.Bot.Builder.AI.QnA.Tests\QnAMakerTests.cs(1989,31): Error CS0121: The call is ambiguous between the following methods or properties: 'QnAMakerDialog.QnAMakerDialog(string, string, string, Activity, float, string, string, int, Activity, Metadata[], Filters, ServiceType, HttpClient, string, int, bool)' and 'QnAMakerDialog.QnAMakerDialog(string, string, string, Activity, float, string, string, int, Activity, Metadata[], Filters, ServiceType, string, int, bool, HttpClient)'Build • Debug_Windows_Configuration_8 • Build solution Microsoft.Bot.Builder.sln |   |     | tests\Microsoft.Bot.Builder.AI.QnA.Tests\LanguageServiceTests.cs(2223,31): Error CS0121: The call is ambiguous between the following methods or properties: 'QnAMakerDialog.QnAMakerDialog(string, string, string, Activity, float, string, string, int, Activity, Metadata[], Filters, ServiceType, HttpClient, string, int, bool)' and 'QnAMakerDialog.QnAMakerDialog(string, string, string, Activity, float, string, string, int, Activity, Metadata[], Filters, ServiceType, string, int, bool, HttpClient)'Build • Debug_Windows_Configuration_8 • Build solution Microsoft.Bot.Builder.sln

[sw-joelmut]

Hi @tracyboehrer, while looking how this will be implemented in JS, we discovered an easier way (using an Authorization header) that involves fewer changes in the code and doesn't require a dependency, that also might work for DotNet.

To maintain parity between the two languages and to avoid introducing the QuestionAnswering package (that has some limitations), we consider that this new way could be implemented instead.

Let us know if you would like us to implement this approach, or if we should keep the QuestionAnswering package with the 'mapping' logic' for DotNet.

[tracyboehrer]

[like] Tracy Boehrer reacted to your message:

…

________________________________ From: Joel Mut ***@***.***> Sent: Tuesday, April 29, 2025 4:28:02 PM To: microsoft/botbuilder-dotnet ***@***.***> Cc: Tracy Boehrer ***@***.***>; Mention ***@***.***> Subject: Re: [microsoft/botbuilder-dotnet] [#6889] CQA to support TokenCredential instead of key (PR #6890) [https://avatars.githubusercontent.com/u/62260472?s=20&v=4]sw-joelmut left a comment (microsoft/botbuilder-dotnet#6890)<#6890 (comment)> Hi @tracyboehrer<https://github.com/tracyboehrer>, while looking how this will be implemented in JS, we discovered an easier way (using an Authorization header) that involves fewer changes in the code and doesn't require a dependency, that also might work for DotNet. To maintain parity between the two languages and to avoid introducing the QuestionAnswering package (that has some limitations), we consider that this new way could be implemented instead. Let us know if you would like us to implement this approach, or if we should keep the QuestionAnswering package with the 'mapping' logic' for DotNet. — Reply to this email directly, view it on GitHub<#6890 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAH2HBUPJJ7XIUWFK3QREVT236SBFAVCNFSM6AAAAAB26TWUISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMZZGUZDCNRWGM>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[ceciliaavila]

We're closing this as a more effective solution has been identified using the Authorization header.