fix: [#4840] The use of the package browserify-sign could violate Microsoft crypto policy #4875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4840
Description
This pull request substitutes the
crypto-browserifypackage in both tsup and webpack browser builds with the native Web Crypto API module. With these changes, thehash.jsdependency causing policy violations is no longer used.Specific Changes
crypto-browserifydependency from both the root package.json and the browser-echo-bot.tsupconfiguration to usewindow.cryptoas the alias for thecryptomodule.webpackconfiguration to usewindow.cryptoas the alias for thecryptomodule.Testing
These images show the browser-echo-bot working after the changes and the hash.js package no longer installed.
