Skip to content

Fix parse-duration usage in cli #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

priitlatt
Copy link
Contributor

NPM package parse-duration version was bumped from 1.1.0 to 2.1.3 In PR #95 for CodePush CLI. This caused the build to fail with the following error:

% npm run build

> code-push-cli@0.0.1 build
> tsc

script/command-parser.ts:1321:21 - error TS2349: This expression is not callable.
  Type 'typeof import("/private/tmp/ms-code-push-server/cli/node_modules/parse-duration/index")' has no call signatures.

1321   return Math.floor(parseDuration(durationString));
                         ~~~~~~~~~~~~~


Found 1 error in script/command-parser.ts:1321

Changes in this PR update parse-duration usages in cli/script/command-parser.ts.

In PR microsoft#95 parse-duration was bumped from version 1.1.0 to 2.1.3 in cli.
This version upgrade was not backwards compatible and caused build to fail.
@priitlatt priitlatt closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant