Skip to content

Update all Power BI reports #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Update all Power BI reports #1258

merged 1 commit into from
Jan 23, 2025

Conversation

flanakin
Copy link
Collaborator

πŸ› οΈ Description

  • Changed KQL reports to use DirectQuery
  • Updated storage reports to align to KQL reports
  • Update visual design of all reports
  • Add feedback links to all pages

πŸ“‹ Checklist

πŸ”¬ How did you test this change?

  • 🀏 Lint tests
  • 🀞 PS -WhatIf / az validate
  • πŸ‘ Manually deployed + verified
  • πŸ’ͺ Unit tests
  • πŸ™Œ Integration tests

πŸ™‹β€β™€οΈ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🀏 The change is less than 20 lines of code.

πŸ“‘ Did you update docs/changelog.md?

  • βœ… Updated changelog (required for dev PRs)
  • ➑️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

πŸ“– Did you update documentation?

  • βœ… Public docs in docs (required for dev)
  • βœ… Internal dev docs in src (required for dev)
  • ➑️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

- Changed KQL reports to use DirectQuery
- Updated storage reports to align to KQL reports
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 265 out of 276 changed files in this pull request and generated no comments.

Files not reviewed (11)
  • src/power-bi/FinOpsToolkitLight.json: Language not supported
  • src/power-bi/kql/CostSummary.Report/StaticResources/RegisteredResources/Microsoft_FinOps_light_theme5385236195184553.json: Language not supported
  • src/power-bi/kql/CostSummary.Report/definition.pbir: Language not supported
  • src/power-bi/kql/DataIngestion.Report/StaticResources/RegisteredResources/Microsoft_FinOps_light_theme6554655019421287.json: Language not supported
  • src/power-bi/kql/DataIngestion.Report/definition.pbir: Language not supported
  • src/power-bi/kql/DataIngestion.SemanticModel/definition/expressions.tmdl: Language not supported
  • src/power-bi/kql/Governance.Report/.platform: Language not supported
  • src/power-bi/kql/Governance.Report/StaticResources/RegisteredResources/Microsoft_FinOps_light_theme9191587775659291.json: Language not supported
  • src/power-bi/kql/Governance.Report/definition.pbir: Language not supported
  • src/power-bi/kql/RateOptimization.Report/StaticResources/RegisteredResources/Microsoft_FinOps_light_theme23216430052051784.json: Language not supported
  • src/power-bi/kql/RateOptimization.Report/definition.pbir: Language not supported

@arthurclares arthurclares merged commit 959f906 into dev Jan 23, 2025
1 check passed
@arthurclares arthurclares deleted the flanakin/dev/pbi-dq branch January 23, 2025 22:56
@flanakin
Copy link
Collaborator Author

flanakin commented Feb 3, 2025

@allcontributors please add danyhoterms for code

Copy link
Contributor

@flanakin

I've put up a pull request to add @DanyhoterMS! πŸŽ‰

@flanakin
Copy link
Collaborator Author

flanakin commented Feb 3, 2025

@allcontributors please add lmoscinski for design

Copy link
Contributor

@flanakin

I've put up a pull request to add @lmoscinski! πŸŽ‰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review πŸ‘€ PR that is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants