Skip to content

Add total savings page in Rate optimization PBI report #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 9, 2025

Conversation

flanakin
Copy link
Collaborator

@flanakin flanakin commented Feb 8, 2025

πŸ› οΈ Description

Add total savings page in Rate optimization PBI report

πŸ“· Screenshots

Screenshot of the Total savings page

πŸ“‹ Checklist

πŸ”¬ How did you test this change?

  • 🀏 Lint tests
  • 🀞 PS -WhatIf / az validate
  • πŸ‘ Manually deployed + verified
  • πŸ’ͺ Unit tests
  • πŸ™Œ Integration tests

πŸ™‹β€β™€οΈ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🀏 The change is less than 20 lines of code.

πŸ“‘ Did you update docs/changelog.md?

  • βœ… Updated changelog (required for dev PRs)
  • ➑️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

πŸ“– Did you update documentation?

  • βœ… Public docs in docs (required for dev)
  • βœ… Internal dev docs in src (required for dev)
  • ➑️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@flanakin flanakin added this to the 2025-02 - February milestone Feb 8, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Documentation πŸ“ PR needs a changelog entry, public docs, or internal docs before it can be closed Needs: Review πŸ‘€ PR that is ready to be reviewed labels Feb 8, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Documentation πŸ“ PR needs a changelog entry, public docs, or internal docs before it can be closed and removed Needs: Documentation πŸ“ PR needs a changelog entry, public docs, or internal docs before it can be closed labels Feb 9, 2025
@flanakin flanakin merged commit 1263f1e into dev Feb 9, 2025
1 check passed
@flanakin flanakin deleted the flanakin/dev/pbi-totalsavings branch February 9, 2025 17:26
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Documentation πŸ“ PR needs a changelog entry, public docs, or internal docs before it can be closed and removed Needs: Documentation πŸ“ PR needs a changelog entry, public docs, or internal docs before it can be closed labels Feb 9, 2025

@flanakin, I noticed you said you would update documentation in a future PR, but this PR is going into the dev branch. All dev branch PRs must have applicable documentation updated to be ready for the next release. Either update the PR to target a feature branch or update the documentation in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Documentation πŸ“ PR needs a changelog entry, public docs, or internal docs before it can be closed Needs: Review πŸ‘€ PR that is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants