-
Notifications
You must be signed in to change notification settings - Fork 135
Update Key Vault to Support Delete Protection #1349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
To be compliant with Enterprise scale policy implementation adding enabling purge protection as true to the keyvault being deployed. Mentioned in the issue here microsoft#1067
Enabled purge protection
|
adding enabling purge protection as the parameter
added enable purge protection parameter and default value false
I have updated the hub.bicep and keyvault.bicep file. Now for the tempalte spec deployment it needs to be added as the parameter there as well. Found src/templates/finops-hub/createUiDefinition.json file where it should be added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please
- Modify the bicep so keyvault is only created when we deploy in the remote hubs scenario.
- Add purge protection to the keyvault.
That should cover the policy requirement without needing an exception and limit it to remote hub style deployments when we need to push data to a remote hub.
We only use AKV in remote hub deployments, and purge protection will cause a lot of support issues for us in scenarios where we're purge protecting an empky keyvault.
@MSBrett Now that we've separated Key Vault from the main deployment and only include it when enabling remote hubs, are you okay with enabling this setting? |
…o pr/ankurshukla03/1349
@ankurshukla03 - We've made the necessary changed to remote hubs and are ready to merge this PR. Could you review the Contributor License Agreement? |
@ankurshukla03 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
To be compliant with Enterprise scale policy implementation adding enabling purge protection as true to the keyvault being deployed. Mentioned in the issue here #1067
🛠️ Description
Property specifying whether protection against purge is enabled for this vault. Setting this property to true activates protection against purge for this vault and its content - only the Key Vault service may initiate a hard, irrecoverable deletion.
Fixes #
📷 Screenshots
📋 Checklist
🔬 How did you test this change?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md
?📖 Did you update documentation?