-
Notifications
You must be signed in to change notification settings - Fork 135
Add GitHub Pages workflow for UX deployment #1404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: features/ux
Are you sure you want to change the base?
Changes from 16 commits
d2ba378
7e8081e
607dcd9
8383ad9
2837b38
bf51a76
d8d6984
c23d0ea
500c30d
be17245
06f2cdd
9af82fe
58f39ab
b852f0f
023c4b2
93d5b61
e77d5dc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
name: Deploy UX to GitHub Pages | ||
on: | ||
# Runs on pushes targeting the default branch | ||
push: | ||
branches: ["features/ux"] | ||
# Allows you to run this workflow manually from the Actions tab | ||
workflow_dispatch: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this need anything or is it intentionally blank? If so, maybe leave a comment so people know it's intentional. |
||
|
||
# Sets the GITHUB_TOKEN permissions to allow deployment to GitHub Pages | ||
permissions: | ||
contents: read | ||
pages: write | ||
id-token: write | ||
|
||
|
||
# Allow one concurrent deployment | ||
concurrency: | ||
group: 'pages' | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
# Single deploy job since we're just deploying | ||
deploy: | ||
environment: | ||
name: github-pages | ||
url: ${{ steps.deployment.outputs.page_url }} | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
- name: Set up Node | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: 20 | ||
cache: 'npm' | ||
- name: Install dependencies | ||
run: npm ci | ||
working-directory: ./src/web | ||
- name: Clean and Build | ||
run: | | ||
rm -rf ./dist || true | ||
NODE_ENV=production npm run build | ||
working-directory: ./src/web | ||
- name: Setup Pages | ||
uses: actions/configure-pages@v4 | ||
- name: List build output | ||
run: ls -la ./src/web/dist | ||
- name: Upload artifact | ||
uses: actions/upload-pages-artifact@v3 | ||
with: | ||
# Upload dist folder | ||
path: './src/web/dist' | ||
- name: Deploy to GitHub Pages | ||
akiskips marked this conversation as resolved.
Show resolved
Hide resolved
|
||
id: deployment | ||
uses: actions/deploy-pages@v4 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"root":["./pages/App.tsx","./pages/AzureOptimizationEnginePage.tsx","./pages/BicepRegistryModulesPage.tsx","./pages/CostOptimizationWorkbookPage.tsx","./pages/FinOpsHubsPage.tsx","./pages/FinOpsWorkbooksPage.tsx","./pages/GovernanceWorkbookPage.tsx","./pages/HomePage.tsx","./pages/OpenDataPage.tsx","./pages/PowerBIReportsPage.tsx","./pages/PowerShellModulePage.tsx","./pages/ToolsLandingPage.tsx","./pages/main.tsx","./pages/__tests__/App.test.tsx","./pages/__tests__/HomePage.test.tsx","./components/__tests__/SideBar.test.tsx"],"version":"5.7.2"} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need to list out every page manually? This seems like it'll break at some point when we forget to add one π Not sure if this is from this PR or another. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Were doing some tests with build and vite preview, I think the TS compiler generated the file for incremental builds. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does the compiler always generate it? Should it be in .gitignore? |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"root":["./vite.config.ts"],"version":"5.7.2"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this goes live, we only want to run it on
main
. It's fine to keep it on this branch for now, however.