Skip to content

gmurphy-finops-toolkit-xcloud-gcp-pipeline #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: features/xcloud
Choose a base branch
from

Conversation

thecloudman
Copy link
Collaborator

No description provided.

…ort as parquest to ingestion container - Basic
Copy link
Collaborator Author

@thecloudman thecloudman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated datafactory bice file with google data set, google pipeline and parameters

@thecloudman
Copy link
Collaborator Author

thecloudman commented Mar 21, 2025 via email

Copy link
Contributor

@microsoft-github-policy-service[bot]

I've put up a pull request to add @thecloudman! 🎉

@flanakin flanakin restored the gcppipeline branch April 4, 2025 08:59
@flanakin flanakin reopened this Apr 4, 2025
enableStaging: false
translator: {
type: 'TabularTranslator'
mappings: [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mappings should be stored in the config/schema folder. We also need to be able to detect and load the correct schema version to account for future updates.

}
inputs: [
{
referenceName: 'GCSbillingexportBucket'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the definition for the dataset and linked service.

We should store the secret in KeyVault.
There's some logic to only deploy KeyVault in the remote hub scenario so that also needs to be updated - likely by adding a checkbox to the UI to optionally deploy KeyVault when deploying the toolkit.

@MSBrett MSBrett added Needs: Attention 👋 Issue or PR needs to be reviewed by the author or it will be closed due to no activity and removed Needs: Review 👀 PR that is ready to be reviewed labels Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Attention 👋 Issue or PR needs to be reviewed by the author or it will be closed due to no activity Skill: Deployment Resource deployment automation via bicep or terraform Tool: FinOps hubs Data pipeline solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants