[Hub apps] Create the hub-pipeline module for creating ADF pipelines #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flanakin
commented
Apr 9, 2025
| dataFactoryName: dataFactory.name | ||
| pipelineName: '${safeConfigContainerName}_InitializeHub' | ||
| pipelineProperties: { | ||
| activities: [ |
There was a problem hiding this comment.
This is mostly spacing changes. To hide spacing changes, use the gear menu above the files 👆 and select "Hide whitespace", then apply and reload.
flanakin
commented
Apr 9, 2025
| params: { | ||
| dataFactoryName: dataFactory.name | ||
| pipelineName: '${safeConfigContainerName}_InitializeHub' | ||
| pipelineProperties: { |
There was a problem hiding this comment.
My main hesitation with this approach is that it removes typing for the pipeline properties. If any app owner wants to hand-craft pipelines, then this would be a painful loss.
The alternative approach is to require people create pipelines using normal bicep and then we have a bicep module that only subscribes pipelines to events. I'm curious what others think 🤔
microsoft-github-policy-service
bot
added
the
Needs: Review 👀
flanakin
changed the title
flanakin
changed the title
flanakin
changed the title
flanakin
added
the
Skill: Deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Creates a placeholder for the hub-pipeline module that will eventually be used for creating and triggering ADF pipelines.
This is a notional PR right now. I'm not convinced this is the right approach because it would lose typing. However, if we move to maintaining pipeline code in JSON files instead of bicep, this would be acceptable. Sharing it to get others' thoughts.
Related to #1400
📋 Checklist
🔬 How did you test this change?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md?📖 Did you update documentation?