Skip to content

[Hub apps] Create the hub-vault module for saving secrets #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025

Conversation

flanakin
Copy link
Collaborator

@flanakin flanakin commented Apr 9, 2025

🛠️ Description

Creates the hub-vault module for savings secrets to the publisher's Key Vault instance.

This doesn't create the vault itself. That would be created in the hub-app module. There's not much to this one. It should be done.

Related to #1400

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@flanakin flanakin added this to the 2025-04 - April milestone Apr 9, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Review 👀 PR that is ready to be reviewed label Apr 9, 2025
@flanakin flanakin changed the title Create a hub-vault bicep module as a placeholder for saving secrets [Hub apps] Create a hub-vault bicep module as a placeholder for saving secrets Apr 9, 2025
@flanakin flanakin added the Tool: FinOps hubs Data pipeline solution label Apr 10, 2025
@flanakin flanakin changed the title [Hub apps] Create a hub-vault bicep module as a placeholder for saving secrets [Hub apps] Create the hub-vault module for saving secrets Apr 10, 2025
@flanakin flanakin enabled auto-merge (squash) April 10, 2025 07:27
@flanakin flanakin requested a review from nteyan April 10, 2025 09:35
@flanakin flanakin added the Skill: Deployment Resource deployment automation via bicep or terraform label Apr 10, 2025
@MSBrett MSBrett added Status: ▶️ Ready Issue is ready for a dev to start work and removed Needs: Review 👀 PR that is ready to be reviewed labels Apr 14, 2025
@flanakin flanakin merged commit 23b5d72 into dev Apr 15, 2025
1 check passed
@flanakin flanakin deleted the flanakin/dev/hubapps-vaultmod branch April 15, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skill: Deployment Resource deployment automation via bicep or terraform Status: ▶️ Ready Issue is ready for a dev to start work Tool: FinOps hubs Data pipeline solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants