Skip to content

FinOps alerts fix for deployment bug #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions docs-mslearn/toolkit/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,23 @@ The following section lists features and enhancements that are currently in deve
**Fixed**
- Workaround subnets reordering and bicep limitation

### [Optimization engine](optimization-engine/overview.md)

- **Fixed**
- Fixed issue with `Remediate-LongDeallocatedVMsFiltered` runbook that was skipping the remediation of eligible VMs due to `Az.Compute` module breaking changes ([#1456](https://github.com/microsoft/finops-toolkit/issues/1456)).

<br><a name="latest"></a>

## v0.10

_Released April 2025_

### [FinOps alerts](alerts/finops-alerts-overview.md) pending updates

- **Fixed**
- Update the 'id' property for the managedApi to a valid scope
- This caused a deployment error because the path could not be deserialized.

### [Optimization engine](optimization-engine/overview.md)

- **Fixed**
- Fixed issue with `Remediate-LongDeallocatedVMsFiltered` runbook that was skipping the remediation of eligible VMs due to `Az.Compute` module breaking changes ([#1456](https://github.com/microsoft/finops-toolkit/issues/1456)).

> [!div class="nextstepaction"]
> [Download](https://github.com/microsoft/finops-toolkit/releases/tag/v0.10)
> [!div class="nextstepaction"]
Expand Down
6 changes: 3 additions & 3 deletions src/templates/finops-alerts/modules/logicApp.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -3729,7 +3729,7 @@ resource finopsAlerts 'Microsoft.Logic/workflows@2019-05-01' = {
{
name: 'resourcesTable'
type: 'string'
value: 'resources@{if(equals(length(variables(\'IncludedSubscriptions\')), 0), \'\', concat(\'| where subscriptionId in ("\', replace(replace(string(variables(\'IncludedSubscriptions\')), \'[\', \'\'), \']\', \'\'), \'")\'))}@{if(equals(length(variables(\'ExcludedSubscriptions\')), 0), \'\', concat(\'| where subscriptionId !in ("\', replace(replace(string(variables(\'ExcludedSubscriptions\')), \'[\', \'\'), \']\', \'\'), \'")\'))}'
value: 'resources@{if(equals(length(variables(\'IncludedSubscriptions\')), 0), \'\', concat(\'| where subscriptionId in ("\', replace(replace(replace(string(variables(\'IncludedSubscriptions\')), \'\\n\', \'\'), \'[\', \'\'), \']\', \'\'), \'")\'))}@{if(equals(length(variables(\'ExcludedSubscriptions\')), 0), \'\', concat(\'| where subscriptionId !in ("\', replace(replace(replace(string(variables(\'ExcludedSubscriptions\')), \'\\n\', \'\'), \'[\', \'\'), \']\', \'\'), \'")\'))}'
}
]
}
Expand Down Expand Up @@ -4183,7 +4183,7 @@ resource finopsAlerts 'Microsoft.Logic/workflows@2019-05-01' = {
office365: {
connectionId: apiConnection.id
connectionName: connectionName
id: resourceId('Microsoft.Web/locations/managedApis', location, 'office365')
id: subscriptionResourceId('Microsoft.Web/locations/managedApis', location, 'office365')
}
}
}
Expand All @@ -4201,7 +4201,7 @@ resource apiConnection 'Microsoft.Web/connections@2016-06-01' = {
location: location
properties: {
api: {
id: resourceId('Microsoft.Web/locations/managedApis', location, 'office365')
id: subscriptionResourceId('Microsoft.Web/locations/managedApis', location, 'office365')
}
displayName:displayName
}
Expand Down