Skip to content

[AOE] Reservations Usage workbook uses the most recent reservation display name #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 21, 2025

Conversation

helderpinto
Copy link
Member

πŸ› οΈ Description

The Reservations Usage workbook has a Reservation filter that is preloaded with the list of all the active reservations. This fix ensure the latest reservation display name is used (in case the reservation display name changed over the course of the lookback period.

Fixes #1455

πŸ“‹ Checklist

πŸ”¬ How did you test this change?

  • 🀏 Lint tests
  • 🀞 PS -WhatIf / az validate
  • πŸ‘ Manually deployed + verified
  • πŸ’ͺ Unit tests
  • πŸ™Œ Integration tests

πŸ™‹β€β™€οΈ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🀏 The change is less than 20 lines of code.

πŸ“‘ Did you update docs/changelog.md?

  • βœ… Updated changelog (required for dev PRs)
  • ➑️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

πŸ“– Did you update documentation?

  • βœ… Public docs in docs (required for dev)
  • βœ… Internal dev docs in src (required for dev)
  • ➑️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@helderpinto helderpinto added Micro PR πŸ”¬ Very small PR that should be especially easy for newcomers Tool: Optimization Engine Azure Optimization Engine labels Apr 18, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Review πŸ‘€ PR that is ready to be reviewed label Apr 18, 2025
@helderpinto helderpinto merged commit 2d198d4 into microsoft:dev Apr 21, 2025
1 check passed
@helderpinto helderpinto deleted the helderpinto/dev/aoe-fix1455 branch April 21, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Micro PR πŸ”¬ Very small PR that should be especially easy for newcomers Needs: Review πŸ‘€ PR that is ready to be reviewed Tool: Optimization Engine Azure Optimization Engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AOE] Reservations Usage workbook is not using the most recent reservation display name
3 participants