Skip to content

Added ability to target all Fabric data store types with create_shortcut_onelake #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

crazy-treyn
Copy link
Contributor

Initially the create_shortcut_onelake function only allowed targeting a Lakehouse as a source. However, the APIs being used to create shortcuts can target any itemId.

This PR includes updates to support creating shortcuts to any kind of Onelake data store item type; Lakehouse, Warehouse, MirroredDatabase, KQLDatabase, and SQLDatabase.

Note: The parameter structure of the function had to change slightly, including names of parameters and a new parameter for the data store type. This will break existing implementations using the original parameter structure of the create_shortcut_onelake function.

@crazy-treyn
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Contributor Author

@crazy-treyn crazy-treyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion. I made the updates, let me know if you think it needs anything else. Cheers

Copy link
Collaborator

@m-kovalsky m-kovalsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment for making code cleaner

@crazy-treyn
Copy link
Contributor Author

Updated. I also made a similar change resolving the name and id of the destination lakehouse using the same resolve_item_name_and_id function for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants